From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BA935E544 for ; Fri, 9 Jan 2026 14:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767968382; cv=none; b=BKwkvEKkz4ktm43Yj1ToUc2e+mFjHKNJYeTGDwPliva9ItJ87DE+Sj3u0EXkkpElH1jG+VLWSlHG12TxJbZouxhBtTaGH4SQ+HzDLm+uKQ6FedOjpqfjy0HWysOh9KZRo+O68MaC8Ko0nC3iKMcpQAJeYPXopLkxV11CEi3/keE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767968382; c=relaxed/simple; bh=WkKu2zRCrZeiRQHlrFcjimJCJ9ltl8LP5VCX9OqltC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p4yhdkRPYN417oPX5VD+BVSQgCY0ICvF6/NNPX20BuxOPhJ4Du8NB0vmztsLBqF7ATAuV+l3kCngrkc497BdMFUpMaHYEtuSnFcfbIu4O57q7wvr7flUSR4Dczz++B5nPS4uiRip4zCo8VLg+4LeD4CfSbAfdaXXUhE9ZZDom64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KF/EVT8i; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KF/EVT8i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767968380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z/6WGCpxh3iEXP0zVTdiymBjWOoqngiNJ6AVVfx3sNs=; b=KF/EVT8i6RTPe09/J8eVJjGeZJP3l444JSdCZdOlCPrviuf/oJoXNBsNoFhkEqvnzc9MtC 28fcz8z0RhC2fRJ+MX2+6QGBSSju74yY/gSxPbCck/MDuD0n8rghB1SOTVAtFrqdNOjMP6 ZrCpvOwWE9RasjULboCQKiFmAHvLGTM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-JKSJUgiINYezc9O3GZUFpg-1; Fri, 09 Jan 2026 09:19:35 -0500 X-MC-Unique: JKSJUgiINYezc9O3GZUFpg-1 X-Mimecast-MFC-AGG-ID: JKSJUgiINYezc9O3GZUFpg_1767968371 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A172195608F; Fri, 9 Jan 2026 14:19:31 +0000 (UTC) Received: from [10.44.33.222] (unknown [10.44.33.222]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 80D741954196; Fri, 9 Jan 2026 14:19:23 +0000 (UTC) Message-ID: <09ffc379-85e5-41ce-b781-66ba6bb9a6c7@redhat.com> Date: Fri, 9 Jan 2026 15:19:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 03/12] dpll: Add helpers to find DPLL pin fwnode To: Krzysztof Kozlowski Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Jonathan Lemon , Richard Cochran , Alexander Lobakin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, Michal Schmidt , Petr Oros , Grzegorz Nitka References: <20260108182318.20935-1-ivecera@redhat.com> <20260108182318.20935-4-ivecera@redhat.com> <20260109-cooperative-chinchilla-of-swiftness-aebbc8@quoll> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20260109-cooperative-chinchilla-of-swiftness-aebbc8@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 1/9/26 10:55 AM, Krzysztof Kozlowski wrote: > On Thu, Jan 08, 2026 at 07:23:09PM +0100, Ivan Vecera wrote: >> Add helper functions to the DPLL core to retrieve a DPLL pin's firmware >> node handle based on the "dpll-pins" and "dpll-pin-names" properties. >> >> * `fwnode_dpll_pin_node_get()`: matches the given name against the >> "dpll-pin-names" property to find the correct index, then retrieves >> the reference from "dpll-pins". >> * `device_dpll_pin_node_get()`: a wrapper around the fwnode helper for >> convenience when using a `struct device`. >> >> These helpers simplify the process for consumer drivers (such as Ethernet >> controllers or PHYs) to look up their associated DPLL pins defined in >> the DT or ACPI, which can then be passed to the DPLL subsystem to acquire >> the pin object. >> >> Signed-off-by: Ivan Vecera >> --- >> drivers/dpll/dpll_core.c | 20 ++++++++++++++++++++ >> include/linux/dpll.h | 15 +++++++++++++++ >> 2 files changed, 35 insertions(+) >> > > I don't see cells defined in your binding. Neither updated property.c. And if the cells are not required? I mean that dpll-names only specifies array of phandles without parameters... e.g. dpll-pin-names = "abc", "def"; dpll-pins = <&dpll_pin_abc>, <&dpll_pin_def>; Should '#dpll-pin-cells' be defined as constantly equal to 0? Thanks, Ivan > > Best regards, > Krzysztof >