From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Walle <michael@walle.cc>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328
Date: Thu, 4 Mar 2021 16:33:03 +0100 [thread overview]
Message-ID: <0A8F3739-E4A2-499F-8B25-C35CF6F811ED@gmail.com> (raw)
In-Reply-To: <CAHp75Vf6+1u5myV7cL1903Qc92H7vPFMuc916-_wjKQ6zwmoqg@mail.gmail.com>
Hi Andy,
> El 4 mar 2021, a las 16:25, Andy Shevchenko <andy.shevchenko@gmail.com> escribió:
>
> On Thu, Mar 4, 2021 at 2:25 PM Álvaro Fernández Rojas <noltari@gmail.com> wrote:
>>> El 4 mar 2021, a las 13:12, Andy Shevchenko <andy.shevchenko@gmail.com> escribió:
>>> On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas <noltari@gmail.com> wrote:
>>>>> El 4 mar 2021, a las 11:49, Andy Shevchenko <andy.shevchenko@gmail.com> escribió:
>>>>> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
>>>>> <noltari@gmail.com> wrote:
>
> ...
>
>>>>>> + BCM6328_MUX_LO_REG,
>>>>>> + BCM6328_MUX_HI_REG,
>>>>>
>>>>>> + BCM6328_MUX_OTHER_REG
>>>>>
>>>>> When it's not terminator add a comma, otherwise remove a comma.
>>>
>>>> … so you want me to add a comma or not?
>>>
>>> Hmm... you tell me! If this is a list which covers all possible cases
>>> _and_ the last one is the kinda maximum value (aka terminator), then
>>> comma is not needed, otherwise add it (to me feels like the latter
>>> should be done here).
>>
>> Well… Then it shouldn’t be needed, since this is a list which covers all possible cases and the last one is a terminator.
>
> Honestly the name suggests otherwise. And looking into the code there
> is no guarantee you won't split that _OTHER_ area to something with
> new compatible hardware.
Every BCM63XX device has its own specific pin controllers.
It seems that on every new SoC created by Broadcom they decided that the previous pin controller approach was a bad decision or something xD.
Therefore I don’t think there will be such “new compatible hardware”...
> Renaming to BCM6328_MUX_MAX_REG will clear that this is terminator,
> but it means its value shouldn't be used except as to understand the
> amount of supported registers of this enumerator.
No, I don’t think this is a good idea.
Please, take a look at:
https://github.com/jameshilliard/gfiber-gflt100/blob/b292e8c271addbda62104bece90e3c8018714194/shared/opensource/include/bcm963xx/6328_map_part.h#L410-L441
As you can see, BCM6328_MUX_LO_REG and BCM6328_MUX_HI_REG are used for specific GPIOs, but BCM6328_MUX_OTHER_REG is used for pins which lack a direct GPIO assignment.
>
>
> --
> With Best Regards,
> Andy Shevchenko
Best regards,
Álvaro.
next prev parent reply other threads:[~2021-03-04 15:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 8:56 [PATCH v4 00/15] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-04 8:56 ` [PATCH v4 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-04 10:33 ` Andy Shevchenko
2021-03-04 10:36 ` Álvaro Fernández Rojas
2021-03-09 16:20 ` Linus Walleij
2021-03-04 8:56 ` [PATCH v4 02/15] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-04 10:35 ` Andy Shevchenko
2021-03-04 15:06 ` Álvaro Fernández Rojas
2021-03-04 15:17 ` Andy Shevchenko
2021-03-04 15:24 ` Álvaro Fernández Rojas
2021-03-04 15:28 ` Andy Shevchenko
2021-03-04 15:44 ` Álvaro Fernández Rojas
2021-03-04 16:33 ` Andy Shevchenko
2021-03-04 16:46 ` Andy Shevchenko
2021-03-04 17:24 ` Michael Walle
2021-03-05 9:44 ` Andy Shevchenko
2021-03-05 7:45 ` Álvaro Fernández Rojas
2021-03-05 9:49 ` Andy Shevchenko
2021-03-04 8:56 ` [PATCH v4 03/15] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-04 10:43 ` Andy Shevchenko
2021-03-04 11:17 ` Álvaro Fernández Rojas
2021-03-04 12:09 ` Andy Shevchenko
2021-03-04 12:28 ` Álvaro Fernández Rojas
2021-03-04 15:19 ` Andy Shevchenko
2021-03-04 8:56 ` [PATCH v4 04/15] Documentation: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 12:53 ` Michael Walle
2021-03-04 8:57 ` [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-04 10:49 ` Andy Shevchenko
2021-03-04 11:13 ` Álvaro Fernández Rojas
2021-03-04 12:12 ` Andy Shevchenko
2021-03-04 12:25 ` Álvaro Fernández Rojas
2021-03-04 15:25 ` Andy Shevchenko
2021-03-04 15:33 ` Álvaro Fernández Rojas [this message]
2021-03-04 15:36 ` Andy Shevchenko
2021-03-04 8:57 ` [PATCH v4 06/15] Documentation: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 07/15] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 08/15] Documentation: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 09/15] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 10/15] Documentation: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 11/15] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 12/15] Documentation: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 13/15] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 14/15] Documentation: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-04 8:57 ` [PATCH v4 15/15] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0A8F3739-E4A2-499F-8B25-C35CF6F811ED@gmail.com \
--to=noltari@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fazilyildiran@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®