From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A614C4332F for ; Thu, 15 Dec 2022 03:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbiLODoz (ORCPT ); Wed, 14 Dec 2022 22:44:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiLODow (ORCPT ); Wed, 14 Dec 2022 22:44:52 -0500 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AD2A5289C for ; Wed, 14 Dec 2022 19:44:50 -0800 (PST) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1671075888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ek1AWVDvL3uGjwPmVZLLu6V363bRYpZOhP1Lu8fyRnA=; b=e4jSCMHBjLLS8F5I0zKPVXVejFpN80ydgHO0I78K+igtJzI85DkC/p6bhJPqPeBhgDFmVh tuLiW6iAmFq0IHHAiSV+4XJEvIrk3CxTyb3bVpWoBg3M5kIUpIzYg40NqbZZQWWa9M7zGw BnmA67tsVkOOEsnRrSvbPnxMG1wqgf8= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20221213212053.106058-1-sidhartha.kumar@oracle.com> Date: Thu, 15 Dec 2022 11:44:14 +0800 Cc: linux-kernel@vger.kernel.org, Linux Memory Management List , Andrew Morton , Muchun Song , Mike Kravetz , Matthew Wilcox , John Hubbard Content-Transfer-Encoding: quoted-printable Message-Id: <0B650D64-1F64-4695-9365-CF695029C50C@linux.dev> References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> To: Sidhartha Kumar X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Dec 14, 2022, at 05:20, Sidhartha Kumar = wrote: >=20 > folio_set_compound_order() is moved to an mm-internal location so = external > folio users cannot misuse this function. Change the name of the = function > to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, > handle the case if a non-large folio is passed and add clarifying = comments > to the function. >=20 > Link: = https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle= .com/T/ > Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions") >=20 > Signed-off-by: Sidhartha Kumar > Suggested-by: Mike Kravetz > Suggested-by: Muchun Song > Suggested-by: Matthew Wilcox > Suggested-by: John Hubbard Reviewed-by: Muchun Song Thanks.=