From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764682AbdJQXAF convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 19:00:05 -0400 Received: from mga14.intel.com ([192.55.52.115]:56803 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757007AbdJQXAD (ORCPT ); Tue, 17 Oct 2017 19:00:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="1206927959" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through Thread-Topic: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through Thread-Index: AQHTQ3War+t9/dvtU0ewwRG9JszmNaLpJcCA Date: Tue, 17 Oct 2017 23:00:02 +0000 Message-ID: <0B7757C2-00D8-47E2-A30D-B7C394E12832@intel.com> References: <661e7cdf247c7662f4f27ac7c54fb4636fd9c1e3.1507781178.git.garsilva@embeddedor.com> In-Reply-To: <661e7cdf247c7662f4f27ac7c54fb4636fd9c1e3.1507781178.git.garsilva@embeddedor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: <605A3CFAFCF1BA4691C05FBEB7361390@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Not sure why you moved the "for mode = 0" comment to a separate line? Not the end of the world though. Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/llite/namei.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c > index 5cc2b32..55e0d03 100644 > --- a/drivers/staging/lustre/lustre/llite/namei.c > +++ b/drivers/staging/lustre/lustre/llite/namei.c > @@ -949,7 +949,9 @@ static int ll_mknod(struct inode *dir, struct dentry *dchild, > > switch (mode & S_IFMT) { > case 0: > - mode |= S_IFREG; /* for mode = 0 case, fallthrough */ > + mode |= S_IFREG; > + /* for mode = 0 case */ > + /* fall through */ > case S_IFREG: > case S_IFCHR: > case S_IFBLK: > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation