From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752077AbcBKGhQ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Feb 2016 01:37:16 -0500
Received: from mga01.intel.com ([192.55.52.88]:33132 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750757AbcBKGhN convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Feb 2016 01:37:13 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,429,1449561600"; 
   d="scan'208";a="46046465"
From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Anton Protopopov <a.s.protopopov@gmail.com>,
        "Berg, Johannes" <johannes.berg@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>, Eran Harary <eran.harary@intel.com>
CC: linuxwifi <linuxwifi@intel.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix erroneous return value
Thread-Topic: [PATCH] iwlwifi: fix erroneous return value
Thread-Index: AQHRZCXqz+Qbh6Z5DkO7sAQI0JXBmQ==
Date: Thu, 11 Feb 2016 06:36:33 +0000
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32EA0DC45@hasmsx107.ger.corp.intel.com>
References: <1455124113-27024-1-git-send-email-a.s.protopopov@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.252.12.29]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 02/10/2016 07:10 PM, Anton Protopopov wrote:
> The iwl_trans_pcie_start_fw() function may return the positive value EIO
> instead of -EIO in case of error.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> index d60a467..920ea9d 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -1034,7 +1034,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
>  	if (trans_pcie->is_down) {
>  		IWL_WARN(trans,
>  			 "Can't start_fw since the HW hasn't been started\n");
> -		ret = EIO;
> +		ret = -EIO;
>  		goto out;
>  	}
>  

applied - thanks.