From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbcGNJol (ORCPT ); Thu, 14 Jul 2016 05:44:41 -0400 Received: from mga03.intel.com ([134.134.136.65]:31977 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbcGNJoi convert rfc822-to-8bit (ORCPT ); Thu, 14 Jul 2016 05:44:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,361,1464678000"; d="scan'208";a="1021487146" From: "Grumbach, Emmanuel" To: Stanislaw Gruszka CC: "prarit@redhat.com" , "linux-kernel@vger.kernel.org" , linuxwifi , "Coelho, Luciano" , "Berg, Johannes" , "kvalo@codeaurora.org" , "Ivgi, Chaya Rachel" , "netdev@vger.kernel.org" , "Sharon, Sara" , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Thread-Topic: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Thread-Index: AQHR24eXahGoAKzzqEy8Xrz19qkGCKATUuyAgAAFUACAAAIuAIAEHy+AgAA3WkA= Date: Thu, 14 Jul 2016 09:44:22 +0000 Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com> References: <1468250301-10357-1-git-send-email-prarit@redhat.com> <5783E33E.7090205@redhat.com> <1468261650.20877.14.camel@intel.com> <20160714092408.GA27271@redhat.com> In-Reply-To: <20160714092408.GA27271@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJjOWMyOTUtNzYxMS00N2RkLWJiZDUtYzg3NWQ4Mzg0YTc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjltOFl6TEFVVStCdVhWRWxiSnJwNlE5YzlWcVN0VFdyNWhOM3NlU3JSbFk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Mon, Jul 11, 2016 at 06:27:30PM +0000, Grumbach, Emmanuel wrote: > > I guess that works, but it seems wrong to me. Usually, registration > > should happen only upon INIT, and yes, at that time the firmware is > > not ready to provide the information yet. > > > > > > > As can be seen in the current code base, iwl_mvm_tzone_get_temp() > > > will return -EIO 100% of the time when the firmware doesn't support > > > reading the > > If I understad correctly this error happen 100% of the time, not only during > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the > time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ). Cur_ucode will not be IWL_UCODE_REGULAR until you load the firmware which will happen upon ifup. > > BTW, you implement thermal_zone device, but do you also need hwmon > device? Perhaps using theramal_zone_params no_hwmon option would be > proper here? That's an interesting direction. I'd have to check, but TBH, I am not familiar with that code. Luca was very involved during the development but he is not available right now. I will be back more the less when the merge window will close :) > > Stanislaw