mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Seraphime Kirkovski <kirkseraph@gmail.com>
Cc: "luca@coelho.fi" <luca@coelho.fi>,
	"Berg, Johannes" <johannes.berg@intel.com>,
	"Coelho, Luciano" <luciano.coelho@intel.com>,
	linuxwifi <linuxwifi@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"open list:INTEL WIRELESS WIFI LINK (iwlwifi)" 
	<linux-wireless@vger.kernel.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: RE: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask
Date: Thu, 8 Jun 2017 08:31:02 +0000	[thread overview]
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB3E55212B0@hasmsx107.ger.corp.intel.com> (raw)
In-Reply-To: <20170608074954.qihkavvqdtwn4zmp@macchiaveli>

> 
> On Thu, Jun 08, 2017 at 06:31:01AM +0000, Grumbach, Emmanuel wrote:
> > Hi,
> 
> Hi,
> 
> > True, OTOH we need tid to be 8 sometimes. We *just* need to make sure
> > that we don't index tid_data with this. Hence I think the proper fix is:
> >
> > diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
> > b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
> > index 06ac3f1..16a8646 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
> > @@ -1190,11 +1190,11 @@ void iwlagn_rx_reply_tx(struct iwl_priv *priv,
> struct iwl_rx_cmd_buffer *rxb)
> >                                 next_reclaimed;
> >                         IWL_DEBUG_TX_REPLY(priv, "Next reclaimed packet:%d\n",
> >                                                   next_reclaimed);
> > +                       iwlagn_check_ratid_empty(priv, sta_id, tid);
> >                 }
> >
> >                 iwl_trans_reclaim(priv->trans, txq_id, ssn, &skbs);
> >
> > -               iwlagn_check_ratid_empty(priv, sta_id, tid);
> >                 freed = 0;
> >
> >                 /* process frames */
> 
> I can confirm it works. You can add my Tested-By.

Patch in review in our internal tree. It'll be upstreamed through the regular process.
Thanks for your report and debug work.

      reply	other threads:[~2017-06-08  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 22:33 Seraphime Kirkovski
2017-06-08  6:31 ` [linuxwifi] " Grumbach, Emmanuel
2017-06-08  7:49   ` Seraphime Kirkovski
2017-06-08  8:31     ` Grumbach, Emmanuel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0BA3FCBA62E2DC44AF3030971E174FB3E55212B0@hasmsx107.ger.corp.intel.com \
    --to=emmanuel.grumbach@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=kirkseraph@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®