From: Ben Nizette <bn@niasdigital.com>
To: me@felipebalbi.com
Cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Subject: Re: Question of resource_size() implementation
Date: Wed, 30 Dec 2009 12:08:34 +1100 [thread overview]
Message-ID: <0CE3DF69-C498-44BA-8CEA-C9AA5DB4CF84@niasdigital.com> (raw)
In-Reply-To: <251FB18F-5D6A-4BBE-A69D-F6203E09058B@niasdigital.com>
On 30/12/2009, at 12:04 PM, Ben Nizette wrote:
>
>
> So resource_size would return SZ_4K and ioremap would map the SZ_4K bytes starting at MEM_AREA1_BASE, i.e. MEM_AREA1_BASE to MEM_AREA1_BASE - 1 /inclusive/. This is also correct.
>
IOW it's a matter of convention. Either we could define a single-byte range to be end=start and put the +1 in the resource_size or we could define a single-byte range to be end=start+1 and leave the +1 out of resource_size. The in-kernel convention is the former
> --Ben.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-12-30 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 23:43 Felipe Balbi
[not found] ` <1262131932.1888.202.camel@Joe-Laptop.home>
2009-12-30 0:16 ` Felipe Balbi
2009-12-30 1:04 ` Ben Nizette
2009-12-30 1:08 ` Ben Nizette [this message]
2009-12-30 1:11 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0CE3DF69-C498-44BA-8CEA-C9AA5DB4CF84@niasdigital.com \
--to=bn@niasdigital.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®