From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03E3C433F5 for ; Fri, 22 Apr 2022 13:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1448305AbiDVOCe (ORCPT ); Fri, 22 Apr 2022 10:02:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344513AbiDVOCZ (ORCPT ); Fri, 22 Apr 2022 10:02:25 -0400 Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA295A14D; Fri, 22 Apr 2022 06:59:29 -0700 (PDT) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1650635966; bh=OPTWL88wx7VdNdMeR/dWu1A51DUlJpqaNYL/YGs6XU4=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=Rbo9vOumJP9KdV5finiGzAkBjNKa7iRrORw6kpRN7GZJVDKj+sDP8c87S3ooJhE8w RmVwoV+40VfncKdNwpM6URe0HikudfpNioWiaVoIAeWelg1UjFDZ3snkX8kd4Ua1fk ZhO9IvMfylt6vU+wjVjf33M2BIv+zqp+rae0xle0= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver From: =?utf-8?Q?Martin_Povi=C5=A1er?= In-Reply-To: Date: Fri, 22 Apr 2022 15:59:25 +0200 Cc: =?utf-8?Q?Martin_Povi=C5=A1er?= , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis , Hector Martin , Sven Peter Content-Transfer-Encoding: quoted-printable Message-Id: <0E735637-EDA8-4A68-8B43-01BCEC41245C@cutebit.org> References: <6F6130F3-381C-4AB7-B618-CDC4C4A37C9B@cutebit.org> <3CD969AD-7316-4D83-AD92-CC85ED817125@cutebit.org> To: Mark Brown Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 22. 4. 2022, at 15:06, Mark Brown wrote: >=20 > On Fri, Apr 22, 2022 at 02:53:54PM +0200, Martin Povi=C5=A1er wrote: >=20 >>> Oh, I see - the speaker actually allows configuration of the slots >>> independently. Usually the left/right thing on mono devices only = does >>> something for I2S where the bus clocking enforces that there be both >>> left and right channels. Either configuration is fine by me TBH, if = you >>> can do that then you could just keep them mapped to the same channel >>> then mark the control as disabled since it should have no effect. >=20 >> Well but is there some established way to mark a control as disabled? >=20 > snd_ctl_activate_id(). Ha! Great. >> Another issue here is that if I disable it I can=E2=80=99t leave the = routing >> control in it=E2=80=99s default value, which is =E2=80=98I2C = Offset=E2=80=99 and makes the speaker >> amp ignore the slot mapping. >=20 > Sure, that's fine - if a control genuinely has no effect it's fine to > hide it from userspace. The issue is where it's just that you don't = see > the use, if the control demonstrably does nothing then that's fine. So I assume I can set the control from the machine driver then disable = it. Anyway, good, this is what I meant earlier when I said the controls I = want to hide are 'useless/confusing at best=E2=80=99. I must walk back that = they are =E2=80=98dangerous at worst=E2=80=99, but I am glad we can hide them = anyway. (Not all of them of course, ISENSE/VSENSE will not be hidden, neither the routing control on systems with single mono speaker.)