From: Song Liu <songliubraving@fb.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>, "tj@kernel.org" <tj@kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>
Subject: Re: [RFC 2/2] perf: Sharing PMU counters across compatible events
Date: Mon, 28 May 2018 18:24:09 +0000 [thread overview]
Message-ID: <0EA2C468-0D02-45A7-AED0-4298E8BC5D87@fb.com> (raw)
In-Reply-To: <20180528111549.GA3452@worktop.programming.kicks-ass.net>
> On May 28, 2018, at 4:15 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, May 04, 2018 at 04:11:02PM -0700, Song Liu wrote:
>> Connection among perf_event and perf_event_dup are built with function
>> rebuild_event_dup_list(cpuctx). This function is only called when events
>> are added/removed or when a task is scheduled in/out. So it is not on
>> critical path of perf_rotate_context().
>
> Why is perf_rotate_context() the only critical path? I would say the
> context switch path is rather critical too.
>
>> @@ -2919,8 +3014,10 @@ static void ctx_sched_out(struct perf_event_context *ctx,
>>
>> if (ctx->task) {
>> WARN_ON_ONCE(cpuctx->task_ctx != ctx);
>> - if (!ctx->is_active)
>> + if (!ctx->is_active) {
>> cpuctx->task_ctx = NULL;
>> + rebuild_event_dup_list(cpuctx);
>> + }
>> }
>>
>> /*
>
>> +static void rebuild_event_dup_list(struct perf_cpu_context *cpuctx)
>> +{
>> + int dup_count = cpuctx->ctx.nr_events;
>> + struct perf_event_context *ctx = cpuctx->task_ctx;
>> + struct sched_in_data sid = {
>> + .ctx = ctx,
>> + .cpuctx = cpuctx,
>> + .can_add_hw = 1,
>> + };
>> +
>> + if (ctx)
>> + dup_count += ctx->nr_events;
>> +
>> + kfree(cpuctx->dup_event_list);
>> + cpuctx->dup_event_count = 0;
>> +
>> + cpuctx->dup_event_list =
>> + kzalloc(sizeof(struct perf_event_dup) * dup_count, GFP_ATOMIC);
>
>
> __schedule()
> local_irq_disable()
> raw_spin_lock(rq->lock)
> context_switch()
> prepare_task_switch()
> perf_event_task_sched_out()
> __perf_event_task_sched_out()
> perf_event_context_sched_out()
> task_ctx_sched_out()
> ctx_sched_out()
> rebuild_event_dup_list()
> kzalloc()
> ...
> spin_lock()
>
> Also, as per the above, this nests a regular spin lock inside the
> (raw) rq->lock, which is a no-no.
>
> Not to mention that whole O(n) crud in the scheduling path...
I think we can also fix the scheduling path. To achieve this, we need
to limit the sharing within the ctx. In other words, events in
cpuctx->ctx can only share PMU with events in cpuctx->ctx, but not
with events in cpuctx->task_ctx. This will probably also solve the
locking issue here. Let me try it.
Thanks,
Song
next prev parent reply other threads:[~2018-05-28 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 23:11 [RFC 0/2] " Song Liu
2018-05-04 23:11 ` [RFC 1/2] perf: add move_dup() for PMU sharing Song Liu
2018-05-04 23:11 ` [RFC 2/2] perf: Sharing PMU counters across compatible events Song Liu
2018-05-28 11:15 ` Peter Zijlstra
2018-05-28 18:24 ` Song Liu [this message]
2018-05-28 11:24 ` Peter Zijlstra
2018-05-28 18:19 ` Song Liu
2018-05-28 11:26 ` Peter Zijlstra
2018-05-28 11:33 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0EA2C468-0D02-45A7-AED0-4298E8BC5D87@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®