From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbdAMBRo convert rfc822-to-8bit (ORCPT ); Thu, 12 Jan 2017 20:17:44 -0500 Received: from mga09.intel.com ([134.134.136.24]:30038 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbdAMBRk (ORCPT ); Thu, 12 Jan 2017 20:17:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,220,1477983600"; d="scan'208";a="212779062" From: "Dilger, Andreas" To: "Guillermo O. Freschi" CC: "Drokin, Oleg" , "lustre-devel@lists.lustre.org" , "linux-kernel@vger.kernel.org" Subject: Re: [lustre-devel] [PATCH 1/2] Fixed signedness check Thread-Topic: [lustre-devel] [PATCH 1/2] Fixed signedness check Thread-Index: AQHSbRyfmrRYEZ/DkU+KKpFm3WepXqE2IYsA Date: Fri, 13 Jan 2017 01:17:39 +0000 Message-ID: <0EF6ABF1-1E3F-46DF-90CA-DA890027DEC4@intel.com> References: <20161226154339.8916-1-kedrot@gmail.com> In-Reply-To: <20161226154339.8916-1-kedrot@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.94.24] Content-Type: text/plain; charset="us-ascii" Content-ID: <68E216D3A9B3B743968161FB0E3EEFD4@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dec 26, 2016, at 08:43, Guillermo O. Freschi wrote: > > Was `unsigned int`, but `enum`s are signed. Interesting that GCC didn't complain that the itree_overlap_cb() function signature didn't match the argument prototype for interval_search(): typedef enum interval_iter (*interval_callback_t)(struct interval_node *node, void *args); In the end it is a somewhat cosmetic fix, because the only enum values (1, 2) were unsigned, but good to be consistent. Thanks for the fix. > Signed-off-by: Guillermo O. Freschi Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c > index a4a291acb659..f4cbc89b4f24 100644 > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c > @@ -1148,7 +1148,7 @@ static int lock_matches(struct ldlm_lock *lock, struct lock_match_data *data) > return INTERVAL_ITER_STOP; > } > > -static unsigned int itree_overlap_cb(struct interval_node *in, void *args) > +static enum interval_iter itree_overlap_cb(struct interval_node *in, void *args) > { > struct ldlm_interval *node = to_ldlm_interval(in); > struct lock_match_data *data = args; > -- > 2.11.0 > > _______________________________________________ > lustre-devel mailing list > lustre-devel@lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org