From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937375AbdJQW5o convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 18:57:44 -0400 Received: from mga07.intel.com ([134.134.136.100]:55510 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932782AbdJQW5k (ORCPT ); Tue, 17 Oct 2017 18:57:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="1231941994" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , Lustre Development List , "Shehata, Amir" , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List Subject: Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through Thread-Topic: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through Thread-Index: AQHTQ3V6B2bxcvJd90a6KkFrHWBvCKLpJRMA Date: Tue, 17 Oct 2017 22:57:37 +0000 Message-ID: <0EFF5864-9A26-49AA-B527-47BA1EC3C079@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: <291C203A5491944488232087A40CDBCB@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This could also just be "continue;", but doesn't appear harmful. Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/lnet/net_fault.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c > index 03f3d18..7391e16 100644 > --- a/drivers/staging/lustre/lnet/lnet/net_fault.c > +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c > @@ -629,6 +629,7 @@ delayed_msg_process(struct list_head *msg_list, bool drop) > case LNET_CREDIT_OK: > lnet_ni_recv(ni, msg->msg_private, msg, 0, > 0, msg->msg_len, msg->msg_len); > + /* fall through */ > case LNET_CREDIT_WAIT: > continue; > default: /* failures */ > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation