mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
	Dan Williams <djbw@kernel.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joao Martins <joao.m.martins@oracle.com>,
	nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] dax: Fix Device DAX range allocation validation
Date: Sat, 19 Sep 2026 13:03:54 +0800	[thread overview]
Message-ID: <0F332745-D70F-4C51-A597-50C1CAE53CCB@linux.dev> (raw)
In-Reply-To: <ab129288-17e8-440d-b544-70ada8925cf0@intel.com>



> On Sep 19, 2026, at 01:02, Dave Jiang <dave.jiang@intel.com> wrote:
> 
> 
> 
> On 9/15/26 2:56 AM, Muchun Song wrote:
>> While working on the HugeTLB Vmemmap Optimization (HVO) generalization,
>> Sashiko reported that memmap_init_zone_device() could be asked to
>> initialize struct pages with a large-page order for a physical range
>> that was not naturally aligned to that order.
>> 
>> Following the Device DAX call path confirmed that the condition was
>> reachable. Device DAX range validation checks the range size, but not
>> its start address. An unaligned range can therefore reach
>> memmap_init_zone_device() after the device binds, and a subsequent write
>> to a userspace mapping may trigger a kernel panic. With the help of an
>> LLM, I was able to reproduce the failure.
>> 
>> The automatic resize path has a related problem. It can split an aligned
>> size request across arbitrary free gaps, consume an unaligned fragment,
>> and leave the resize partially applied when a later allocation fails.
>> 
>> This series validates both the start and size of every Device DAX range
>> and makes automatic resize account only for usable aligned space. It
>> also fixes the mapping sysfs attribute to propagate validation failures
>> instead of reporting success without allocating the requested range.
>> 
>> Muchun Song (2):
>>  dax/bus: fix Device DAX range alignment validation
>>  dax/bus: fix mapping attribute error reporting
>> 
>> drivers/dax/bus.c | 144 +++++++++++++++++++++++++++++++++++-----------
>> 1 file changed, 109 insertions(+), 35 deletions(-)
>> 
>> 
>> base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3
> 
> This commit does not exist in Linus's tree. Can you please base the series on top of the latest 7.3-rc tag so sashiko can look over it? Thanks!

Hi,

The series is based on linux-next 20260914, and drivers/dax/bus.c is identical
between that branch and the latest 7.3-rc. Sashiko has also already reviewed it
here: [1].

Therefore, I didn't quite catch your point. Are you expecting Sashiko to conduct
another round of review based on the 7.3-rc code? (Are you concerned about issues
introduced by the additional commits in linux-next compared to 7.3-rc?)

[1] https://sashiko.dev/#/patchset/20260915095621.3744167-1-songmuchun%40bytedance.com

Thanks,
Muchun



      reply	other threads:[~2026-09-19  5:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  9:56 Muchun Song
2026-09-15  9:56 ` [PATCH 1/2] dax/bus: fix Device DAX range alignment validation Muchun Song
2026-09-15  9:56 ` [PATCH 2/2] dax/bus: fix mapping attribute error reporting Muchun Song
2026-09-18 17:02 ` [PATCH 0/2] dax: Fix Device DAX range allocation validation Dave Jiang
2026-09-19  5:03   ` Muchun Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0F332745-D70F-4C51-A597-50C1CAE53CCB@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@kernel.org \
    --cc=joao.m.martins@oracle.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=songmuchun@bytedance.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®