From: Chuck Lever <chuck.lever@oracle.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Patrick J. LoPresti" <lopresti@gmail.com>,
Andi Kleen <andi@firstfloor.org>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Proposal: Use hi-res clock for file timestamps
Date: Wed, 18 Aug 2010 14:15:51 -0400 [thread overview]
Message-ID: <0F91AB9D-0E14-4384-ADD6-0A467C3ABFAC@oracle.com> (raw)
In-Reply-To: <20100818173203.GC32430@fieldses.org>
On Aug 18, 2010, at 1:32 PM, J. Bruce Fields wrote:
> On Wed, Aug 18, 2010 at 03:53:59PM +1000, Neil Brown wrote:
>> I'm not sure you even want to pay for a per-filesystem atomic access when
>> updating mtime. mnt_want_write - called at the same time - seems to go to
>> some lengths to avoid an atomic operation.
>>
>> I think that nfsd should be the only place that has to pay the atomic
>> penalty, as it is where the need is.
>>
>> I imagine something like this:
>> - Create a global struct timespec which is protected by a seqlock
>> Call it current_nfsd_time or similar.
>> - file_update_time reads this and uses it if it is newer than
>> current_fs_time.
>> - nfsd updates it whenever it reads an mtime out of an inode that matches
>> current_fs_time to the granularity of 1/HZ.
>
> We can also skip the update whenever current_nfsd_time is greater than
> the inode's mtime--that's enough to ensure that the next
> file_update_time() call will get a time different from the inode's
> current mtime.
Would it help if we only did this for directories, for now?
Files have close-to-open. Directories... don't. So we have the problem where directory changes (ie file creation and deletion) takes a long time (some times an infinitely long time) to propagate to clients. Plus: directories don't change very often, so using fine-grained time stamps only on directories wouldn't impact heavy I/O workloads.
> And that means that a sequence like
>
> file_update_time()
> N nfsd_getattr()'s
>
> doesn't make N updates to current_nfsd_time, when only 1 was necessary.
>
>> If the current value is before current_kernel_time, it
>> is set to current_kernel_time, otherwise tv_nsec is incremented -
>> unless that increases
>> beyond jiffies_to_usec(1)*1000 beyond current_kernel_time.
>
> ... which would only happen on hardware that could process a getattr and
> a data update per nanosecond continuously for a jiffy.
>
>> - the global 'struct timespec' is zeroed whenever system time is set
>> backwards.
>
> OK, got it, I think: so this is the same as a global version of Alan's
> clock, except that the extra ticks only happen when they need to.
>
> The properties it satisfies:
>
> - It's still a single global clock, so it's consistent between
> files.
> - It degenerates to jiffies in the absence of getattr's from
> nfsd.
> - It need only invalidate the other cpus' cached value of the
> clock on the first getattr of a file that follows less than a
> jiffy after an update of the file's data.
> - Absent utime(), time going backwards, or futuristic hardware,
> it guarantees that two nfsd reads of an inode's mtime will
> return different values iff the inode's data was modified in
> between the two.
>
> Shortcomings:
>
> - The clock advances in units only of either 1 jiffy or 1 ns.
> This will look odd. But when the alternative is units of 1
> jiffy or 0 ns, it seems an improvement....
> - A slowdown due to inodes being file_update_time() marking inodes
> dirty more frequently?
> - Doesn't help with ext3. Oh well.
>
> Would the extra expense rule out treating sys_stat() the same as nfsd?
> It would be nice to be able to solve the same problem for userspace
> nfsd's (or any other application that might be using mtime to save
> rereading data).
>
> --b.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
chuck[dot]lever[at]oracle[dot]com
next prev parent reply other threads:[~2010-08-18 18:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 18:25 Patrick J. LoPresti
2010-08-13 18:45 ` john stultz
2010-08-13 18:57 ` Patrick J. LoPresti
2010-08-13 19:09 ` john stultz
2010-08-13 20:53 ` Patrick J. LoPresti
2010-08-14 16:45 ` Patrick J. LoPresti
2010-08-15 1:50 ` Bret Towe
2010-08-17 14:54 ` Andi Kleen
2010-08-17 17:41 ` J. Bruce Fields
2010-08-17 18:29 ` Andi Kleen
2010-08-17 18:50 ` Patrick J. LoPresti
2010-08-17 19:04 ` J. Bruce Fields
2010-08-17 19:18 ` Patrick J. LoPresti
2010-08-17 19:39 ` Alan Cox
2010-08-17 19:29 ` J. Bruce Fields
2010-08-17 19:52 ` Alan Cox
2010-08-18 5:53 ` Neil Brown
2010-08-18 14:46 ` Patrick J. LoPresti
2010-08-18 17:32 ` J. Bruce Fields
2010-08-18 18:15 ` Chuck Lever [this message]
2010-08-18 23:41 ` Neil Brown
2010-08-19 0:52 ` Neil Brown
2010-08-19 2:08 ` J. Bruce Fields
2010-08-19 2:44 ` Neil Brown
2010-08-19 22:46 ` J. Bruce Fields
2010-08-18 23:47 ` Neil Brown
2010-08-18 17:50 ` Andi Kleen
2010-08-18 18:54 ` J. Bruce Fields
2010-08-18 19:25 ` Andi Kleen
2010-08-18 19:30 ` J. Bruce Fields
2010-08-17 19:34 ` Patrick J. LoPresti
2010-08-17 19:54 ` Alan Cox
2010-08-17 19:43 ` Patrick J. LoPresti
2010-08-17 19:45 ` J. Bruce Fields
2010-08-18 18:12 ` J. Bruce Fields
2010-08-19 1:41 ` john stultz
2010-08-19 2:31 ` J. Bruce Fields
2010-08-19 3:17 ` john stultz
2010-08-19 22:53 ` J. Bruce Fields
2010-08-18 18:20 ` David Woodhouse
2010-08-18 18:32 ` Patrick J. LoPresti
2010-08-18 18:53 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F91AB9D-0E14-4384-ADD6-0A467C3ABFAC@oracle.com \
--to=chuck.lever@oracle.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lopresti@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®