From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-526614-1517276967-2-2020193519053183454 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.137', Host='smtp4.osuosl.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='UNK' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517276966; b=xFQNcyIZVT/lwli4qBsx9zs0bqIrtCnA1MGDSiwbPh24SWX h1IdbTuUd1pdR9PCPK/WMGNHPgmuMRnod+pOa8vnpl+qJtSCy9u/5LHK2UuB/Pfv t02qxp1s1V4YHPVequzRT/AbgR4AowasLTG7EEf6pRCbiQ/SY19oAVTrknJc2OaE axNuC81kRj8/LkUSE62TDkVCG3D/vKkHryfpefLGEfq+vvXoBdTszv0tX+QPBJQ4 uc2DiocHnWfmv9lr53eSD3ZFJ5bgYReqW/2ALOnwb/D3pSAjeRVjy4GfXftCxxbf ggxaFqt4UPeyy4d7LHs/KolOVhQ7NPGypXx7gww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :references:in-reply-to:content-id:mime-version:list-id :list-unsubscribe:list-archive:list-post:list-help :list-subscribe:cc:content-type:content-transfer-encoding :sender; s=arctest; t=1517276966; bh=cxF6VflU+sAOqdhPHR50wqJ/+9s jViq+L5bdq1mfxCg=; b=k3jkmZ9h4KD6fEWKfa7t8X9Fi0W7yCG8jnZYzzQDoVh ifVrvHjjYu55kSoiR6geeV6H6g/vf3GM1ooSbzRs16Vdf0Ifoc0Z4D7VXNkGNHw+ DI8mwqLRBb8fAOG5Socv+xNUAT5hOldGQLxY4/knJDyzcULn9OLN7D5lg1OPJD4y opzHBrnDFKYMZKUCjK2oIGIL2GltBRRprBlTcYYowfvGh0592gbSTNKvpVXeIh52 MllmFXUVEH6LVBRpBbfe7YVtwTcdnWaQJug7axP+TWhUlW6aFuR4SQjJw1w2tO+3 eGYd9qs+iK9/Os+tIDyosuG1TDlnfTnHSMJBemqyUzA== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=intel.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=intel.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="170164962" From: "Dilger, Andreas" To: Sumit Pundir Subject: Re: [PATCH] staging: lustre: lnet: return of an error code should be negative Thread-Topic: [PATCH] staging: lustre: lnet: return of an error code should be negative Thread-Index: AQHTl/hfDO3jnUZ0b02sAZoHjG51zqOMLz6A Date: Tue, 30 Jan 2018 01:49:17 +0000 Message-ID: <0FF5C462-31A2-4D8F-9288-EE941D37826B@intel.com> References: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com> In-Reply-To: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.105.141] Content-ID: <6D81DEA5132B314AAF427D5F291D0A39@intel.com> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "Drokin, Oleg" , "lustre-devel@lists.lustre.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Jan 27, 2018, at 22:24, Sumit Pundir wrote: > > Return value of error codes should typically be negative. > Issue reported by checkpatch.pl > > Signed-off-by: Sumit Pundir Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/selftest/framework.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c > index c7697f6..0ca1e3a 100644 > --- a/drivers/staging/lustre/lnet/selftest/framework.c > +++ b/drivers/staging/lustre/lnet/selftest/framework.c > @@ -187,7 +187,7 @@ sfw_del_session_timer(void) > return 0; > } > > - return EBUSY; /* racing with sfw_session_expired() */ > + return -EBUSY; /* racing with sfw_session_expired() */ > } > > static void > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel