From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AB8C433F5 for ; Tue, 15 Mar 2022 18:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351136AbiCOSoM (ORCPT ); Tue, 15 Mar 2022 14:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351122AbiCOSoF (ORCPT ); Tue, 15 Mar 2022 14:44:05 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF85F04; Tue, 15 Mar 2022 11:42:52 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: shreeya) with ESMTPSA id 3439F1F4303B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647369771; bh=OqBz4qNcyZ8R5pFma1baORhNdguifW2BoSXyepNU+m4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SKhbQisBAbD2ljdjGfwkMMG1lX3B5SLyBKin3hdMyXoPGgvGQ3dR75hz2J2fWgM4F mNRog7HcWuwr4xXOmp+cdZngXqx0gg8X/vBl3J7B9FlUcNRewT1IZs5VDggdrvG+Fr ja7vtn8dFRgRkCtoscrtNiCkV/wz/ayg5RkNj2fNgS8cwUZeqr2CbjmetK6U/HSG+0 kCO1/MtrF52P5Jp5CafUZ3E7QyMANcYsEVBENHTSVoIJaiuc3KlU3M6e2fuMYxLcCY C2MlFgGbqfuboxPD3VcD9EkAJgMVJeIXu56gb81DuAVy5QUmVUrUUamaQrhfNhcG5n laG4KdHzLDaHg== Subject: Re: [PATCH v2] gpio: Restrict usage of gc irq members before initialization To: Andy Shevchenko , kernel test robot Cc: Linus Walleij , Bartosz Golaszewski , krisman@collabora.com, kbuild-all@lists.01.org, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Collabora Kernel ML References: <20220315103813.84407-1-shreeya.patel@collabora.com> <202203160100.PENzQsMs-lkp@intel.com> From: Shreeya Patel Message-ID: <0a011be5-6f08-a9dc-3e62-f9296c7b9d2e@collabora.com> Date: Wed, 16 Mar 2022 00:12:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/22 11:35 pm, Andy Shevchenko wrote: > On Tue, Mar 15, 2022 at 7:38 PM kernel test robot wrote: >> Hi Shreeya, >> >> Thank you for the patch! Yet something to improve: > >> All errors (new ones prefixed by >>): >> >> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq': >>>> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq' >> 3068 | if (gc->to_irq && gc->irq.gc_irq_initialized) { >> | ^~ > Exactly, because this check should go under ifdeffery. Makes sense to me now. gc->irq.initialized must be checked inside gpiochip_to_irq() wrapped around an ifdef CONFIG_GPIOLIB_IRQCHIP Thanks Andy, I'll send a v3 with this change. Shreeya Patel