mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: Borislav Petkov <bp@alien8.de>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Pedro Falcato <pfalcato@suse.de>,
	dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, tglx@kernel.org, mingo@redhat.com,
	x86@kernel.org, hpa@zytor.com, riel@surriel.com,
	linux-kernel@vger.kernel.org, qi.zheng@linux.dev,
	nadav.amit@gmail.com, thomas.lendacky@amd.com,
	kernel-team@meta.com, linux-mm@kvack.org,
	akpm@linux-foundation.org, brendan.jackman@linux.dev,
	jannh@google.com, mhklinux@outlook.com, Manali.Shukla@amd.com,
	mingo@kernel.org, stable@vger.kernel.org, toshi.kani@hpe.com,
	david@kernel.org, mikhail.v.gavrilov@gmail.com
Subject: Re: [PATCH 1/1] x86/mm: fix incomplete page-table invalidation with TCE
Date: Mon, 5 Oct 2026 22:58:52 +0800	[thread overview]
Message-ID: <0a0f7ae5-5fa0-430c-8074-9217f594a563@linux.dev> (raw)
In-Reply-To: <20261005145315.GCasO523MWyIIx2ngl@fat_crate.local>



On 2026/10/5 22:53, Borislav Petkov wrote:
> On Mon, Oct 05, 2026 at 10:36:26PM +0800, Lance Yang wrote:
>> I don't have an AMD machine to test this on. I spotted something
>> that looked wrong in the code and sent it out to see what others
>> think.
> 
> You send a normal mail - not a patch.
>   
>> Maybe I'm reading the manual wrong, but is raising a concern
>> based on the code and the manual really just "a wild hunch"?
> 
> If it is formulated like a patch which is supposed to be even urgent, then
> you're reading our process wrong.
> 
> https://docs.kernel.org/process/development-process.html
> 
> And since you have not tested it to actually fix anything, then this patch is
> nothing but a wild hunch.
> 
> And to answer your question, no, it is not needed. Definitely not the TCE
> angle.
> 
> Now, the speculative thing is another story but that whole story you're
> referring to needs a lot more debugging.
> 
> But we do not apply patches on a wild hunch, without any definitive data that
> they fix an issue and, if very much possible, with a clear explanation why
> they fix it.

OK, let's drop the patch.

  reply	other threads:[~2026-10-05 14:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05  5:23 Lance Yang
2026-10-05  5:47 ` Andrew Morton
2026-10-05  6:09 ` Pedro Falcato
2026-10-05  7:29   ` Lance Yang
2026-10-05  8:19     ` Andrew Cooper
2026-10-05  8:32       ` Lance Yang
2026-10-05  9:57         ` Andrew Cooper
2026-10-05 10:12           ` Lance Yang
2026-10-05 14:22             ` Borislav Petkov
2026-10-05 14:36               ` Lance Yang
2026-10-05 14:53                 ` Borislav Petkov
2026-10-05 14:58                   ` Lance Yang [this message]
2026-10-05 15:22             ` Andrew Cooper
2026-10-05 15:36               ` Lance Yang
2026-10-05 10:24     ` Pedro Falcato
2026-10-05 12:10       ` Lance Yang
2026-10-05  6:38 ` Nadav Amit
2026-10-05  7:23   ` Lance Yang
2026-10-05 15:15 ` Rik van Riel
2026-10-05 15:30   ` Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a0f7ae5-5fa0-430c-8074-9217f594a563@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=Manali.Shukla@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=brendan.jackman@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pfalcato@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=riel@surriel.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®