From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0E8EE6447 for ; Fri, 15 Sep 2023 09:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233241AbjIOJDW (ORCPT ); Fri, 15 Sep 2023 05:03:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233143AbjIOJDU (ORCPT ); Fri, 15 Sep 2023 05:03:20 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B1B30DA for ; Fri, 15 Sep 2023 02:01:47 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3496366072BA; Fri, 15 Sep 2023 09:58:37 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694768317; bh=QvOarZtm9q0/2Kba7YS408C3On3CckrdIr72iCDGik0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=R69HQPLoeSJeRPnLMYl37vbwbaKYVtZ638yOLvIiYj8GORIrmSChH0A86OyLeP3WK szQREpUVuA8jzgUFa1NzVasateqS26xlwtwPcVMmnLLQmlKDdbnraH2fDpaAMRythX pbctN3GX+1bMVJ18SZIHOgyF1WeOzbz8IsX00JFpnAlPV8Kp4yRj2FKGLttIc+83bg V5ITMSFDWwLqcxc1+UNzeknVQ6RWXUTm4kt1xIqs1jMVxIP7yjjMdtidGnnjSofEwY wmUAoyN9wNxHI9lSerXXcAcsKk+99WTGY0yYqfxPguiez+aWO/cUCcGJellnTtL4RA xR7TrWis50apQ== Message-ID: <0a184b35-133b-483c-d475-01120fbdc2ca@collabora.com> Date: Fri, 15 Sep 2023 10:58:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] drm/mediatek: dsi: Fix EOTp generation Content-Language: en-US To: Michael Walle , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger Cc: Jitao Shi , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230915075756.263591-1-mwalle@kernel.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230915075756.263591-1-mwalle@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 15/09/23 09:57, Michael Walle ha scritto: > The commit c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register > definition") inverted the logic of the control bit. Maybe it was because > of the bad naming which was fixed in commit 0f3b68b66a6d ("drm/dsi: Add > _NO_ to MIPI_DSI_* flags disabling features"). In any case, the logic > wrong and there will be no EOTp on the DSI link by default. Fix it. > > Fixes: c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register definition") > Signed-off-by: Michael Walle Hello Michael, your commit is missing a small piece! :-) Besides, I've already sent a fix for what you're trying to do here: https://lore.kernel.org/linux-arm-kernel/07c93d61-c5fd-f074-abb2-73fdaa81fd65@collabora.com/T/ Cheers, Angelo > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index d67e5c61a9b9..8024b20f6b13 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -407,7 +407,7 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi) > if (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) > tmp_reg |= HSTX_CKLP_EN; > > - if (!(dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)) > + if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) > tmp_reg |= DIS_EOT; > > writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL);