From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793301998; b=CKGoNJ5kUrxQTaoUJdDNGH2K8mNg0mpVfBIiLT/KHOIIRsZxD0CTCJmobKjSzdAIq3Uc NQKOU9zxR4TkXvXAIK9WYtQpD1qcezXxQ7HWCv61zFjJ3V5A08W/nUmQ7DdkMh2p1v3iz nqfOQRc9o3bTKjCv8Gp2rCOD1Ng7ZAUl7ECsIBr8guNHgnw0HtPz7b7ynFArZ4E+B1vPn RBzEhXDLzSkAyAgEguxAI0jU8Lb3ANndXD5X9cc09RCADJuX5wzSiNI6QZGQt96K3Wn6j hCblfAvuHRgy/B6Gc0SwNzARahn+wJEr3SBv9LEfiUMeEmv2dxVUA8nH8r80vJvalxg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793301998; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=olq2oLw59YhnpeUJwxDmzWejxUeT+/sp90poHb2MYpE=; b=ATKbgDg4k34QHeea4ieE8g7PT1f2EANyw/otOJwHBnVwdRZoz9kxaLQlOWmOy7UONAXd GP6B5+r4iRDuryPkAx0FWq3kBoYB+aRnUXSbJwHD4pQhePbLdiqxKl7ToyUiqcLxJlICP pxilwWSdusHHidRJ8qH8nQ90hK05tVFqt8ccK/AjVbw+JIC89cwvJLzwBDkX+sHbS5qP3 n0c1STOBMOKjmskSPt8pP+2iTUcO4ZRSj9XR3BoTHn+iTq6853yclRKGqaqtkfuCvWpaM hh7pRfagvsBoVGV5A4tBME24rqrBBzbnn0I1r3YTs/0INQ2z6aFvChJ9Nyj9wrggEKw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Vuz79kYO; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A96606A31A; Thu, 29 Oct 2026 19:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Vuz79kYO Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B31D1F01816; Thu, 29 Oct 2026 19:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793301997; bh=olq2oLw59YhnpeUJwxDmzWejxUeT+/sp90poHb2MYpE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Vuz79kYOC25Pp9Lahkn6JIoGjLKWZgFMbszt9wdYOSUiNklBr4qPAG+Z4n0nCZ1A0 eTnnRFm9Rw4IsBqS8OzDtTl17wf+e48vjls768zrm5h2RnQ9WeHLCsdOSWJIIaeEOb YML9LUIT7+G5zuOu3mOEaeFf/7OJ1Hauz1eLBtTE5Z/wfuS50OqrjJRgjI1JwBkGI+ kF1Ii/KT98x8jXIXfkV/UZVqCgi8xq9PU4qG3X67p4XghMEn7hf338VOMdjyjL/U8R ylDOaPrnvYV/ZL/kdu/Wn3yRVQ8rZ1F8Hz7yZiCTmDjZVn9p2Tb1lfA9FPtv+/Sj+Z orROyVbGDU/Kg== Message-ID: <0a1ad7d2-ff0e-4248-8f03-2a64a9134aae@kernel.org> Date: Thu, 29 Oct 2026 20:26:33 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/filemap: stop fault-around when the walk steps back To: "Jose Fernandez (Anthropic)" , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Krystian Kaniewski References: <20261028-jf-mm-filemap-map-pages-lower-bound-v1-1-0bf126e876d4@linux.dev> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261028-jf-mm-filemap-map-pages-lower-bound-v1-1-0bf126e876d4@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/29/26 16:50, Jose Fernandez (Anthropic) wrote: > filemap_map_pages() can dereference a PTE pointer outside the page table > it locked. KASAN has reported this as a use-after-free read [1]. Only read or also write? I assume only read. > > Its fault-around loop walks the page cache and moves vmf->pte by the > change in index. A lower index moves it back. xas_find() can step back > to a lower index when a multi-index entry is split during the walk. > > [1] fixes xas_find(), but the loop still relies on the walk never > stepping back. Stop the fault-around when the walk steps back. ->fault() > maps the faulting page if the loop did not. > > Link: https://lore.kernel.org/20260904121301.200049-1-krystianmkaniewski@gmail.com [1] > Signed-off-by: Jose Fernandez (Anthropic) > --- > mm/filemap.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/filemap.c b/mm/filemap.c > index b74bc1e5015c..1df776907140 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3968,6 +3968,13 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, > unsigned long end; > vm_fault_t map_ret; > > + /* A lower index could move vmf->pte out of its page table. */ > + if (unlikely(xas.xa_index < last_pgoff)) { > + folio_unlock(folio); > + folio_put(folio); > + break; > + } > + > addr += (xas.xa_index - last_pgoff) << PAGE_SHIFT; > vmf->pte += xas.xa_index - last_pgoff; > last_pgoff = xas.xa_index; Sounds like we want a Fixes: tag and Cc: stable? :) -- Cheers, David