From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B20FC27C7C for ; Fri, 20 Jan 2023 16:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjATQP3 (ORCPT ); Fri, 20 Jan 2023 11:15:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjATQP1 (ORCPT ); Fri, 20 Jan 2023 11:15:27 -0500 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29BE0C4E93 for ; Fri, 20 Jan 2023 08:15:21 -0800 (PST) Received: by mail-il1-x135.google.com with SMTP id b15so792760ils.11 for ; Fri, 20 Jan 2023 08:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8q+osopjEj5UV3uSdXLaRXg7Go12BXAi8Q5kyHgZLzM=; b=AvojiM0Z1FRoMv0sAipWHK+54Fg8PZXAKfISB4C9WyAKPAvjwXHfeH+LSUTxtlOAWQ myoIXkt4/lNWpHyWJtNLLXTL+LwhS3Sih0egnSdWC1hH5S9xpZBDDilfQgaLEE2XagKG WbO/aEilF+o2KsrDwkAsa8F87oT69of4q4WEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8q+osopjEj5UV3uSdXLaRXg7Go12BXAi8Q5kyHgZLzM=; b=57cD1v4CrPubmEjijpXB+RnYEgRStnpc8XRPdezw/jz/+BT8bgYdywXF/vOlPRIl5w hMAkoJ6HYwOqkMFqD62UAdEQBYY7DCyO8L+GxJjp937VuRxuNPBTuAwpd66HImjyI0g/ /qF76Vt2p7jr2zzrYmTFzJCMyoU6Q7sz1nONV7JD+aDK4nKLUU+I56wG5PboAgspZwKp 9QDC1QZd8zA9s96VLz6uu/67sydWgKfn8rjBeraC+BJjq9daQ0ypITRVJMzs2x2p9OU1 Xyd6y4AYybM8SCpv+JpD10ipDEHlI19gDJY+7gxYHUMtCit5f76MeFFLdWjusEnLbqtl s55Q== X-Gm-Message-State: AFqh2kpvRVvclUelL/JmeHvEfVpoRB3wOHy4wyJrW+PuLsurre0k8V0v P7Nr4l4kcz44PlgrMpSSQEI0JA== X-Google-Smtp-Source: AMrXdXukx36xY+oeMJ8jlQhSlgQ7DFkkSJM08imR7xKNmkF/kWguHew/k1ksNW9KAW0MdVAa6UXkAg== X-Received: by 2002:a92:d3c2:0:b0:30f:4feb:50c7 with SMTP id c2-20020a92d3c2000000b0030f4feb50c7mr434920ilh.3.1674231320300; Fri, 20 Jan 2023 08:15:20 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id p16-20020a92d290000000b00302632f0d20sm475827ilp.67.2023.01.20.08.15.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 08:15:19 -0800 (PST) Message-ID: <0a1ae8e9-ab0e-038a-084f-240f73489010@linuxfoundation.org> Date: Fri, 20 Jan 2023 09:15:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile To: sedat.dilek@gmail.com, Huang Rui Cc: Doug Smythies , "Rafael J. Wysocki" , "Meng, Li (Jassmine)" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , linux-kselftest@vger.kernel.org, Shuah Khan References: <001201d92c93$98c8a040$ca59e0c0$@telus.net> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/20/23 09:11, Sedat Dilek wrote: > On Fri, Jan 20, 2023 at 10:17 AM Huang Rui wrote: >> >> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: >>> Revert the portion of a recent Makefile change that incorrectly >>> deletes source files when doing "make clean". Ooo. That is bad. >>> >>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") >>> Reported-by: Sedat Dilek >>> Tested-by: Sedat Dilek >>> Signed-off-by: Doug Smythies >> >> (+ Shuah and linux-kselftest mailing list) >> >> Thanks for fix! >> >> Acked-by: Huang Rui >> > > [ I already replied - but with these important CCs ] > > Hi Doug, > > Thanks for the patch! > > Small nit, I saw this with: What did you see and should that be fixed as well. > > $ make -C tools/ clean > > Otherwise: > > Reviewed-by: Sedat Dilek > Send me the revised patch with all the right CCs and I will pull this right away. thanks, -- Shuah