mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: regression: LTP isofs testcase failure - bisection fingers "loop: make autoclear operation asynchronous"
Date: Tue, 18 Jan 2022 04:21:54 +0100	[thread overview]
Message-ID: <0a1c1464e40e4c60687bc715c0b78c9124e456f8.camel@gmx.de> (raw)
In-Reply-To: <c53285e4-cbd4-5fd0-cbc9-93e2e3d3d88d@I-love.SAKURA.ne.jp>

On Tue, 2022-01-18 at 06:57 +0900, Tetsuo Handa wrote:
> On 2022/01/18 0:34, Mike Galbraith wrote:
> > Greetings,
> >
> > LTP's isofs testcase began failing this cycle, and bisected as below,
> > which a revert then confirmed.  Full testcase output attached.
> >
>
> Thanks for reporting.
> Discussion is continued at https://lkml.kernel.org/r/cdaf1346-2885-f0da-8878-12264bd48348@I-love.SAKURA.ne.jp .

FWIW, simply immediately flushing that shiny new rundown_work turned
LTP's thumb back to upward pointing.

---
 drivers/block/loop.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1197,6 +1197,7 @@ static void loop_schedule_rundown(struct
 	kobject_get(&bdev->bd_device.kobj);
 	INIT_WORK(&lo->rundown_work, loop_rundown_workfn);
 	queue_work(system_long_wq, &lo->rundown_work);
+	flush_work(&lo->rundown_work);
 }

 static int loop_clr_fd(struct loop_device *lo)


  reply	other threads:[~2022-01-18  3:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 15:34 Mike Galbraith
2022-01-17 21:57 ` Tetsuo Handa
2022-01-18  3:21   ` Mike Galbraith [this message]
2022-01-18  6:19     ` Tetsuo Handa
2022-01-19 20:48       ` Mike Galbraith
2022-02-08  3:16   ` Mike Galbraith
2022-02-08 12:37     ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a1c1464e40e4c60687bc715c0b78c9124e456f8.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®