mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyj.lk@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] brd: make symbol rd_size static
Date: Sun, 30 Oct 2016 20:40:12 +0800	[thread overview]
Message-ID: <0a1d6cbb-6797-e295-0d9c-7e814c1ebb21@gmail.com> (raw)
In-Reply-To: <e8c13474-d035-7e03-1eee-a0ccf7a5c799@kernel.dk>

On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>>  symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
>         extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.

Thank you very much.

Regards,
Yongjun Wei

  reply	other threads:[~2016-10-30 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29 16:10 Wei Yongjun
2016-10-30  3:57 ` Jens Axboe
2016-10-30 12:40   ` Wei Yongjun [this message]
2016-10-30  9:46 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a1d6cbb-6797-e295-0d9c-7e814c1ebb21@gmail.com \
    --to=weiyj.lk@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®