mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Wenliang <wenliang202407@163.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux dev 6.11] hwmon:add new hwmon driver sq52205
Date: Sun, 25 Aug 2024 15:50:29 -0700	[thread overview]
Message-ID: <0a1df032-dfb6-4a26-a27d-14cc301cf12c@roeck-us.net> (raw)
In-Reply-To: <20240822074426.7241-1-wenliang202407@163.com>

On 8/22/24 00:44, Wenliang wrote:
> Thank you for bringing up your questions and suggestions.The SQ52205 is a
> part number specific to the Asian region, which is why you might not be
> able to find it through a search. I'll provide you the website
> (https://us1.silergy.com/zh/productsview/SQ52205FBP).

That page does not point to the chip datasheet. The almost identical
page at https://us1.silergy.com/productsview/SQ52205FBP does.
The datasheet is _not_ "Publicly available" as claimed in this submission.
The version I was able to obtain is tagged with "Silergy Confidential For
<my employer>", so I am not even sure if I can use it to review this driver
submission.

> Some registers of this chip are similar to those of the INA226, but it has
> additional registers such as integrators, which is the main reason why I'm
> offering a new driver.And I plan add drivers of the same series based on

That is not a reason to add a separate driver. Look at, for example, lm90.c,
which supports a variety of chips in a single driver. The ina2xx driver already
does support several chips, and adding another one would be straightforward,
even if it is from a different manufacturer. On top of that, only the EIN and
ACCUM_CONFIG registers are additional, and the rest appear to be exactly the
same as INA226.

> this. I commit the new patch and look forward to your reply.
> 

Additonal comments:
- Please review and follow
   Documentation/process/submitting-patches.rst
   Documentation/hwmon/submitting-patches.rst
- As mentioned before, a reworked version of the ina2xx.c driver is
   available. I am not inclined to accept a new driver for this chip.
   Even if I were, I would not accept a driver based on deprecated
   hwmon APIs. I would strongly advise to have a look into the reworked
   driver. As mentioned before, it is available in the hwmon-staging branch
   of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git.
- "calculate_avg_power" is (unnecessarily) not a standard attribute and
   therefore unacceptable. Its value (on top of the already averaged power
   attribute) seems questionable. I would understand an attempt to report
   the energy, but I fail to understand the value in reporting yet another
   power average - even more so one that is not well defined in terms of
   number of samples used to determine the average.

Guenter


  reply	other threads:[~2024-08-25 22:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <935f564b-fa3e-4cdf-bf12-19b897369a07@roeck-us.net>
2024-08-22  7:44 ` Wenliang
2024-08-25 22:50   ` Guenter Roeck [this message]
2024-08-30 16:08     ` Guenter Roeck
2024-09-11 12:25       ` [PATCH linux dev-6.11 1/2] hwmon: modified ina2xx to match SY24655(SQ52205) Wenliang
2024-09-11 12:25         ` [PATCH linux dev-6.11 2/2] dt-bindings: " Wenliang
2024-09-11 17:49           ` Conor Dooley
2024-10-08 12:35             ` Krzysztof Kozlowski
2024-10-08 16:26               ` Conor Dooley
     [not found]             ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com>
2024-10-08 16:17               ` Conor Dooley
2024-09-11 15:15         ` [PATCH linux dev-6.11 1/2] hwmon: " Guenter Roeck
2024-10-12  7:06           ` [PATCH linux dev-6.11 1/2] v3: hwmon: modified ina2xx to match SY24655 Wenliang
2024-10-12  7:06             ` [PATCH linux dev-6.11 2/2] v3: dt-bindings: " Wenliang
2024-10-12 10:06               ` Krzysztof Kozlowski
2024-10-12 12:12                 ` Guenter Roeck
2024-09-11 17:04         ` [PATCH linux dev-6.11 1/2] hwmon: modified ina2xx to match SY24655(SQ52205) Christophe JAILLET
     [not found]       ` <28adb212.c4f4.1926bff2cf0.Coremail.wenliang202407@163.com>
2024-10-08 16:37         ` [PATCH linux dev-6.11 1/2] v3: hwmon: modified ina2xx to match SY24655 Guenter Roeck
2024-08-26  8:28   ` [PATCH linux dev 6.11] hwmon:add new hwmon driver sq52205 kernel test robot
2024-08-26 16:46   ` kernel test robot
2024-09-13  5:29   ` kernel test robot
2024-09-13 23:49   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a1df032-dfb6-4a26-a27d-14cc301cf12c@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wenliang202407@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®