From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23391C3A5A7 for ; Tue, 6 Dec 2022 08:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232435AbiLFI0J (ORCPT ); Tue, 6 Dec 2022 03:26:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230480AbiLFI0G (ORCPT ); Tue, 6 Dec 2022 03:26:06 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4BA2E0D5 for ; Tue, 6 Dec 2022 00:26:04 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id a7so16330071ljq.12 for ; Tue, 06 Dec 2022 00:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OkMxJjoW8X4kUNC+47c7765KzpRNV4xbB6ThuqIXaYA=; b=g7x6H4cWlQJYECi+8ttT+RfB1nYdfNW9EGfg3yL2ZSCKJzsrTlP9H+YuWwotc2pTyW shOdEKTrbkHbyrusr8EHbTlAkluPeftoC4Uzu44f7DI/6kwPn6sU1zafHnA24XvFX49O ClEDTzTODxK5PYAIErwbkN/pc0HIs+EIh02NhHO8XKNyMlmz5ZMxiC92dQ7Klpr38FcL HdnAg+WZZfFU4uki65XSz+HL4vc411PpfBLYLUHlGkWM+SYuONwyD0ggxZd6S3GdU4Aw Wc+MhpH4G9cxIG04n/C0Y9DVTrW4ydlDCrLLXFyEcJwHgpHrZxn/fQcEP7R39qY6M6fR 0vZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OkMxJjoW8X4kUNC+47c7765KzpRNV4xbB6ThuqIXaYA=; b=a8duQFD77K6p7I0G9SkyPzlpEbTnNcpzbtniGZR9eCUT8i31QuZdnGv/hjKSPZ6Ud7 /yTDC6XLBp+5dBq2FwIWF96VZk4FPKqPsV65l4RkKwofx/AAs9j/oIsOUQSCSXXyOm5Y Z/wBi0ifmtWsft3SjFyRbJx/Nu9y/ON/UrViER6ngSw21V572onC1ZdR4CPDYIBM1i5T nwpgEMtM9gtIMqoG4BSVLobfoyjuiE4xW3acSstNX9cgscslpqcSZa94w0Wy+VJ7YAuo fOT+wRjkjibi0GnUUcGFyPmgkIngXmfWRzi/N5SIJ1EB1IvpXuvuvAqAOwkprg3d9o0v cWtw== X-Gm-Message-State: ANoB5pmwpw3/ZC8TQKNrDhX2U+ADoW+Qlx5ny6QkXwugKdESLW3ma2XE pcCfYfu7YJhibGbJP1DdfbxeZQ== X-Google-Smtp-Source: AA0mqf5hJt4mcZkr+hduYVC1h4gFFiYEe5e/seICQH3DF+vHQDg04AGpXBwDBxE+G5FcRm2BXk2Vwg== X-Received: by 2002:a2e:b8c3:0:b0:277:2e91:e9d6 with SMTP id s3-20020a2eb8c3000000b002772e91e9d6mr22193667ljp.372.1670315162821; Tue, 06 Dec 2022 00:26:02 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s8-20020a056512214800b004b4823f02b0sm2411927lfr.152.2022.12.06.00.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 00:26:02 -0800 (PST) Message-ID: <0a2056f9-0126-4dd7-55fa-930ce61e2e81@linaro.org> Date: Tue, 6 Dec 2022 09:26:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Content-Language: en-US To: JiaJie Ho , Rob Herring Cc: "linux-crypto@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Rob Herring , Herbert Xu , Krzysztof Kozlowski , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "David S . Miller" References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <166981596611.1846501.537832446745968339.robh@kernel.org> <14a3facb1fe642cba0048f2f2d0eb2e9@EXMBX068.cuchost.com> From: Krzysztof Kozlowski In-Reply-To: <14a3facb1fe642cba0048f2f2d0eb2e9@EXMBX068.cuchost.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2022 04:48, JiaJie Ho wrote: > > >> -----Original Message----- >> From: Rob Herring >> Sent: Wednesday, November 30, 2022 9:48 PM >> To: JiaJie Ho >> Cc: linux-crypto@vger.kernel.org; linux-riscv@lists.infradead.org; Rob >> Herring ; Herbert Xu >> ; Krzysztof Kozlowski >> ; linux-kernel@vger.kernel.org; >> devicetree@vger.kernel.org; David S . Miller >> Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto >> driver >> >> >> On Wed, 30 Nov 2022 13:52:13 +0800, Jia Jie Ho wrote: >>> Add documentation to describe Starfive crypto driver bindings. >>> >>> Signed-off-by: Jia Jie Ho >>> Signed-off-by: Huan Feng >>> --- >>> .../bindings/crypto/starfive-crypto.yaml | 109 ++++++++++++++++++ >>> 1 file changed, 109 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/crypto/starfive-crypto.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m >> dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/crypto/starfive- >> crypto.example.dts:21:18: fatal error: dt-bindings/clock/starfive-jh7110.h: No >> such file or directory >> 21 | #include >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> make[1]: *** [scripts/Makefile.lib:406: >> Documentation/devicetree/bindings/crypto/starfive-crypto.example.dtb] >> Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [Makefile:1492: dt_binding_check] Error 2 >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree- >> bindings/patch/20221130055214.2416888-6-jiajie.ho@starfivetech.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> > > Hi Rob Herring, > > The #include in example have dependencies on the following patches: > https://patchwork.kernel.org/project/linux-riscv/cover/20221118010627.70576-1-hal.feng@starfivetech.com/ > https://patchwork.kernel.org/project/linux-riscv/cover/20221118011714.70877-1-hal.feng@starfivetech.com/ > I've noted them in the cover letter. > How do I add them in this patch? You cannot. Testing bot does not take dependencies, so it did not have above clock IDs. This also should point your attention that if crypto maintainers pick up this patch, they also won't have the clock IDs so their tree will have such failure as well. You can wait with your patch till dependency hits mainline or you can just replace clock IDs with numbers and drop the header (and later you can correct the example if needed... or leave it as is). Best regards, Krzysztof