From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbcHACKH (ORCPT ); Sun, 31 Jul 2016 22:10:07 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:15885 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750805AbcHACKC (ORCPT ); Sun, 31 Jul 2016 22:10:02 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="9358478" Subject: Re: [PATCH v2 1/2] vfio : resume notifier To: Alex Williamson References: <1468914765-22585-1-git-send-email-zhoujie2011@cn.fujitsu.com> <20160729111158.362b2698@t450s.home> CC: , , , , Chen Fan From: Zhou Jie Message-ID: <0a21858d-29da-a1df-8938-d3a8caf77365@cn.fujitsu.com> Date: Mon, 1 Aug 2016 10:05:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160729111158.362b2698@t450s.home> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-yoursite-MailScanner-ID: 392CD42B549F.ADDCB X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: zhoujie2011@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Alex On 2016/7/30 1:11, Alex Williamson wrote: > On Tue, 19 Jul 2016 15:52:45 +0800 > Zhou Jie wrote: > >> From: Chen Fan > > An empty commit log is unacceptable for all but the most trivial > patches. > > There's also no sign-off on this patch. Sorry. I should note it. > I also don't know why we need this since you previously found that for > QEMU, ordering of error versus resume notifications is not guaranteed, > which is why I thought we went with a status flag within the struct > vfio_device_info. I'm not adding an interrupt to the user that has > no users. This was not part of the most recent discussion we had about > this, so I'm lost why this patch exists. Thanks, > > Alex I will remove the resume interrupt. Sincerely ZhouJie