From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D6C2EC54C for ; Mon, 19 Jan 2026 20:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855064; cv=none; b=mkt3WdeJCFMb6/WOAiVMIGhxaNHtAJSxsxZlGWf+lEIjr6VHyAjAaUWNHFirTHRE4LcxtZJvdOH8NmhkGiY7m3UYPApxFYWo7IeKRkCstB6FMwi2RW1uiY7D01/K97j/fAIvPZxlz4KWd89yjz2pvlZp+cp4ZfMYmw9ijxNDOnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855064; c=relaxed/simple; bh=YA4vN+4ReplHxz2m3b9bFg9dLEcGhNL33RenmFV0B+I=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qVUvnGzNkvvwfD3YP/PW4hRFK7+Bez8yn3cKjvs0TqHU5iqwnlentF9cKzQ5QL6NzGqb62avKJ/+32bZhHsRdabtpINmaLz9SjjOZLf3qgK4DHJe3ULZJnKLyV4dWLUaYyeLEwl+ESeA/eABcgxO5zwqV9XHvYKloWDyV6upMcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gyQuD8EO; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gyQuD8EO" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2b6f85470b6so270247eec.1 for ; Mon, 19 Jan 2026 12:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768855062; x=1769459862; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=obxFYhoxSkY4ewKsf8MOe+lJXVK2fvzWgYRyrUOL5ZU=; b=gyQuD8EOPqIhJwWHi8gFpzdXPjhR1clJoUwMrWhDvYoBYbY+OIir5ykuMdV0joJ2VF AZu3BFb/rgVxR6bZ/cWn1q1hmFk2YJHCZA5CbYrHiiFERmYdJ5f/SXjFQw9kySVEnNfR g4IOYfTsuvo2MYvYxWRbkMrp3lyNVPSpiFkq9MDOOYdZw28nM3uy4BZde0Xxau9iP7qh FL/p6vIdgtlRskoeizF7cCByzg0nnc/geMV9ctJzysd0LZKEHkCgsBuIidWIMLWGQOZc MTbLL5MS5LApslXJUovXe+cH7cfSnYfPblSk9nB5jribb+MT+het4eiRBUgMSnr352RU zIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768855062; x=1769459862; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=obxFYhoxSkY4ewKsf8MOe+lJXVK2fvzWgYRyrUOL5ZU=; b=OhxkeFoeNh4/zqzam5ECC6SwAsp4vx4JGzcYzUQViSTc1Wt7BkpaYOL20B6d9+fdK0 jPUEU3i5uwbZnRSmSwTlUwLrJ1hhTIdz+NRYLmGE5IlMho8VqsxL5lsPXRzymCHxngHx Lm5hhv5pUTOx85aqbmLMI0MlvRtL6/EYMtqhOCsY8duDDcH0CeDZ+DMFWWVuwJ9/rWNT 3X3PQaDmTWx2YL2fmmXPwiyoqRKNzLVCa0ydxmYpmO32FqfHPGPPPfp9UzZm2ObdX4Wx K1OF5xPA3KZkQiAe8zfFJGByKse/L6VaM/2Xgyj0DsZry8GtUePSfKuH79KhXsShOS/B 7YDA== X-Forwarded-Encrypted: i=1; AJvYcCUeHX1xEn6ct8ZIbMUCmDm0GwOUGAVVSdhx9m2gjPJ+hAolS6jNomgf7UgM2fpkdkgeRNrbDMjesrVn4D4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxyd4UM+fCtxhEyWntwrDQfEIp3wkOtT+mGBI1nkkRsusuSALMe oQsJSKSwKP73o0gtOGHjg9uwoNzssyC3IvEB7gSeOZC68MSJZVQQg0Sc X-Gm-Gg: AZuq6aLrAnKAXYUkjuFJGoQaF49s6WunZcAPsKeCubfB6flc8Q48HqOZLVEE2QtXSHd EUPYksJ6HqqOShpULONxki5pkEwQVYi8CY+aNaSY7BQefyYroKT6ard/fTyqwACXFpvQlF7JxJx y97ITtu3H507bRqJ6Yx1ZoPUanyRFNcFs3DcXlJpjY9ZmyJ/MHPhDjGOk5ciO+46FEKR1EMvUtR jmmYSIi3ENpg6x9kEcK/dWEmm9go1c7YL1kNxABr6WWx0AiFi+73mhHSuNVJNRbwlnPaDY9R8Rb 0vHtXDZlrd/a74v/fIEPaAUGhjc0rdLpoouezwUQ8zNT+/zw+OdnTZPt5X2t8VNYuM/9FDtLBT/ Y+Vc9lp2E6WyLiEcPo7+wUY1FW5dJ8utuYSVQlldkSjqs18G9Yo2+XaekfrYUK2DGPic0PCAswi p004vmEjvzMnoY8/H8kDm/PhbOdekkrkKmCF5lzfZYlXsL0AZtkYyT8jsG8/7lVWW+Sg== X-Received: by 2002:a05:7301:4104:b0:2af:cd0a:ef75 with SMTP id 5a478bee46e88-2b6b414bdc4mr8473914eec.34.1768855062294; Mon, 19 Jan 2026 12:37:42 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:4cd6:17bf:3333:255f? ([2620:10d:c090:500::aa81]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b34c11dasm16121656eec.2.2026.01.19.12.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 12:37:41 -0800 (PST) Message-ID: <0a277a7ff97395803d114a0ea74a5cab9fd75237.camel@gmail.com> Subject: Re: [PATCH bpf-next v5 2/2] selftests/bpf: test the jited inline of bpf_get_current_task From: Eduard Zingerman To: Menglong Dong , ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 19 Jan 2026 12:37:39 -0800 In-Reply-To: <20260119070246.249499-3-dongml2@chinatelecom.cn> References: <20260119070246.249499-1-dongml2@chinatelecom.cn> <20260119070246.249499-3-dongml2@chinatelecom.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 15:02 +0800, Menglong Dong wrote: > Add the testcase for the jited inline of bpf_get_current_task(). >=20 > Signed-off-by: Menglong Dong > --- > .../selftests/bpf/prog_tests/verifier.c | 2 ++ > .../selftests/bpf/progs/verifier_jit_inline.c | 35 +++++++++++++++++++ > 2 files changed, 37 insertions(+) > create mode 100644 tools/testing/selftests/bpf/progs/verifier_jit_inline= .c >=20 > diff --git a/tools/testing/selftests/bpf/prog_tests/verifier.c b/tools/te= sting/selftests/bpf/prog_tests/verifier.c > index 38c5ba70100c..2ae7b096bd64 100644 > --- a/tools/testing/selftests/bpf/prog_tests/verifier.c > +++ b/tools/testing/selftests/bpf/prog_tests/verifier.c > @@ -111,6 +111,7 @@ > #include "verifier_xdp_direct_packet_access.skel.h" > #include "verifier_bits_iter.skel.h" > #include "verifier_lsm.skel.h" > +#include "verifier_jit_inline.skel.h" > #include "irq.skel.h" > =20 > #define MAX_ENTRIES 11 > @@ -253,6 +254,7 @@ void test_verifier_bits_iter(void) { RUN(verifier_bit= s_iter); } > void test_verifier_lsm(void) { RUN(verifier_lsm); } > void test_irq(void) { RUN(irq); } > void test_verifier_mtu(void) { RUN(verifier_mtu); } > +void test_verifier_jit_inline(void) { RUN(verifier_jit_inl= ine); } > =20 > static int init_test_val_map(struct bpf_object *obj, char *map_name) > { > diff --git a/tools/testing/selftests/bpf/progs/verifier_jit_inline.c b/to= ols/testing/selftests/bpf/progs/verifier_jit_inline.c > new file mode 100644 > index 000000000000..0938ca1dac87 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/verifier_jit_inline.c > @@ -0,0 +1,35 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include > +#include > +#include "bpf_misc.h" > + > +#if defined(__TARGET_ARCH_x86) || defined(__TARGET_ARCH_arm64) I don't think this #if is necessary as well as 'dummy_test'. test_loader.c:run_subtest() checks current architecture against a mask supplied by __arch_* annotations and skips the test for unsupported archs. > + > +SEC("fentry/bpf_fentry_test1") > +__description("Jit inline, bpf_get_current_task") Nit: please don't use __description() for new tests, it makes "./test_progs -t" tests selection harder. > +__success __retval(0) > +__arch_x86_64 > +__jited(" addq %gs:{{.*}}, %rax") > +__arch_arm64 > +__jited(" mrs x7, SP_EL0") > +int inline_bpf_get_current_task(void) > +{ > + bpf_get_current_task(); > + > + return 0; > +} > + > +#else > + > +SEC("kprobe") > +__description("Jit inline is not supported, use a dummy test") > +__success > +int dummy_test(void) > +{ > + return 0; > +} > + > +#endif > + > +char _license[] SEC("license") =3D "GPL";