From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbdLYVCL (ORCPT ); Mon, 25 Dec 2017 16:02:11 -0500 Received: from mout.web.de ([217.72.192.78]:59635 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbdLYVCH (ORCPT ); Mon, 25 Dec 2017 16:02:07 -0500 To: linux-gpio@vger.kernel.org, John Crispin , Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] pinctrl: xway: Delete two error messages for a failed memory allocation in pinmux_xway_probe() Message-ID: <0a27abb0-c222-765b-3a96-7e02163a0858@users.sourceforge.net> Date: Mon, 25 Dec 2017 22:02:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:GME0y/kUtUT0re+h+IVbKdd1BL88adAeJxY7gY5koyI2VA5XS80 6KKD6QHcibR/wVN/Jk0MXm2mQ04jDenAENf/p/GunJcf4Ga4xgkwr7gbglmjF29dR+42PxP LdX1tQPSca/gCqxViwsWv0VvLXzFPSnpikUNGgZn55JnodfOJu1SNnM7NFyrs9vk96STHQP ec1zhZqNV7oIrUCpgpQIA== X-UI-Out-Filterresults: notjunk:1;V01:K0:7WlrGk7T1yE=:nTlBnlp5YtlKxWZutvls61 4cEVPTuT/oWS9i2rRsYbaTINp3umJiC25ozgMlJxzeBZeKzxYflNteGWU5SxTXmMGG5IpSG6B xgZ1tB83obtTIsCoB7YwnABBLLbchQ1Gf728XZb+ODD6wk1JPn5GlVRFnzcTXvZ9hmKSVak8l Ql92VwFNxFQNsnmMIprHsNuKVnI87UHbBBEc7o0a8u7EcQVKOUrXjq8Jz7MonnElgLgspznje Zfj0SKrGvyx6lpr2iRx/ADk7EMWc6mdMBQ5OIHrfOUFPiwY3LXH4SyIfJHckcVx86Jz1HRn/X CltT65sTn6URPreocSBJTkFGbXE8ODRpu20ifrPt1dDkXkaUsDAUux/Lr3BnZGoBraddQU5Nu /lv81OxKmyK25sd0NysDszgBTKHKo0G2S/mDE+QHm2GyiZpFJqPg+P99bwMfrkFhFi2lEgNry 2cZxudMcoqB3yJWg3RsxwyQHMCHJxzzQ0FazqlANdijw9Ezp4Bc7StEgrRefxPN8bnXmn99Zv b0opGyH+VBhdqYq2fGXyneuJ7p0haEjORYWToj/7ELXPNh+EvXr4bZVz5x0MMHAWd17wOquJ/ yxhsSGq9X4UDhiF/yJQ5tpiMdkobkX5aI/S4o9bDTfGvlFmFnFkK0cjdIbKcJRy13ChIwX2WS X5jFpSsDFxp7deOlsv0iXHgDfiCxdPue0WLAzoG5u2Aic6QD5St2Xy1MYSnUXPvtDX+wrd3BR b/UH9f/tiVERt8fdMYSsXdvcDxvv4DdgMGeL1sc5pV2tyOuse8IMq0vrMEWDs34TfelJ/C5+c dB3bNYyY7kN6qCpZdSkQbp9iGC+LRTWfxkKfzWUmaWqJ1flPrI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 25 Dec 2017 21:51:26 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-xway.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c index f9e98a7d4f0c..cd0f402c1164 100644 --- a/drivers/pinctrl/pinctrl-xway.c +++ b/drivers/pinctrl/pinctrl-xway.c @@ -1730,18 +1730,16 @@ static int pinmux_xway_probe(struct platform_device *pdev) xway_info.pads = devm_kzalloc(&pdev->dev, sizeof(struct pinctrl_pin_desc) * xway_chip.ngpio, GFP_KERNEL); - if (!xway_info.pads) { - dev_err(&pdev->dev, "Failed to allocate pads\n"); + if (!xway_info.pads) return -ENOMEM; - } + for (i = 0; i < xway_chip.ngpio; i++) { /* strlen("ioXY") + 1 = 5 */ char *name = devm_kzalloc(&pdev->dev, 5, GFP_KERNEL); - if (!name) { - dev_err(&pdev->dev, "Failed to allocate pad name\n"); + if (!name) return -ENOMEM; - } + snprintf(name, 5, "io%d", i); xway_info.pads[i].number = GPIO0 + i; xway_info.pads[i].name = name; -- 2.15.1