From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C546C433FF for ; Wed, 14 Aug 2019 02:40:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C015214DA for ; Wed, 14 Aug 2019 02:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbfHNCk0 (ORCPT ); Tue, 13 Aug 2019 22:40:26 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4254 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727182AbfHNCkX (ORCPT ); Tue, 13 Aug 2019 22:40:23 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 71FB0567C5C78BC6698F; Wed, 14 Aug 2019 10:40:20 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Wed, 14 Aug 2019 10:40:15 +0800 Subject: Re: [PATCH linux-next] drivers: dma: Fix sparse warning for mux_configure32 To: Vinod Koul References: <20190812074205.96759-1-maowenan@huawei.com> <20190813044327.GR12733@vkoul-mobl.Dlink> CC: , , , From: maowenan Message-ID: <0a29e584-2385-9e7c-8d13-3ba47d3bf81c@huawei.com> Date: Wed, 14 Aug 2019 10:40:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190813044327.GR12733@vkoul-mobl.Dlink> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/13 12:43, Vinod Koul wrote: > On 12-08-19, 15:42, Mao Wenan wrote: > > Patch title is incorrect, it should mention the changes in patch, for > example make mux_configure32 static > > Do read up on Documentation/process/submitting-patches.rst again! > >> There is one sparse warning in drivers/dma/fsl-edma-common.c, > > It will help to explain the warning before the fix > >> fix it by setting mux_configure32() as static. >> >> make allmodconfig ARCH=mips CROSS_COMPILE=mips-linux-gnu- >> make C=2 drivers/dma/fsl-edma-common.o ARCH=mips CROSS_COMPILE=mips-linux-gnu- > > Make cmds are not relevant for the log > >> drivers/dma/fsl-edma-common.c:93:6: warning: symbol 'mux_configure32' was not declared. Should it be static? > > This one is and should be retained > >> >> Fixes: 232a7f18cf8ec ("dmaengine: fsl-edma: add i.mx7ulp edma2 version support") >> Signed-off-by: Mao Wenan >> --- >> drivers/dma/fsl-edma-common.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c >> index 6d6d8a4..7dbf7df 100644 >> --- a/drivers/dma/fsl-edma-common.c >> +++ b/drivers/dma/fsl-edma-common.c >> @@ -90,8 +90,8 @@ static void mux_configure8(struct fsl_edma_chan *fsl_chan, void __iomem *addr, >> iowrite8(val8, addr + off); >> } >> >> -void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, >> - u32 off, u32 slot, bool enable) >> +static void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, > > just change this to static > >> + u32 off, u32 slot, bool enable) > > and dont change anything else. > > If you feel to change this, propose a new patch for this line explaining > why this should be changed thanks, I will send v2. > >> { >> u32 val; >> >> -- >> 2.7.4 >