From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4C6C38A2D for ; Wed, 26 Oct 2022 01:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231748AbiJZBR4 (ORCPT ); Tue, 25 Oct 2022 21:17:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbiJZBRx (ORCPT ); Tue, 25 Oct 2022 21:17:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80206C2CAA for ; Tue, 25 Oct 2022 18:17:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1431461C4B for ; Wed, 26 Oct 2022 01:17:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9E6C433D6; Wed, 26 Oct 2022 01:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666747070; bh=wOZM+oyBXIQ35iD4e8i/HPoDGliVpVT3G5QL4pHtCHI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KjxblEtYkDKjNwJ8VsL3Wu5qqrR3r+cRA9AzCCnoW3NbrHdnpv5DGQqiCcgh4HWta rX/qtOzJdSP5T8KFE3FbK6jVPC5lMmYtfK3XNu7YkUoIIikTH8ev57C+I0PH2BXiga Ypoq1mW1gveyQRLnXTh3qUhWcGk+9i502SWYaFVaujfYzXaC3f3A2aI2v6Rp2pCCDg XbupuPLwPdNtb0iiErCG8dwS7AC9a9tfYeCLcF/itpN1esqgQO4wSTqhQMfJcgSnJ4 1kXf3t5QuIjvzmKGja2lvVs7mIPxp/hdIKSM+TrMHIffaBUSELFLQAgFyRvGsDiM+A 6Ea5ObtPK4WHQ== Message-ID: <0a339e33-d79a-19e4-fadd-bb37a5a9f79d@kernel.org> Date: Wed, 26 Oct 2022 09:17:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [f2fs-dev] [PATCH] f2fs: allow to set compression for inlined file Content-Language: en-US To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20221024233634.803695-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/10/26 1:46, Jaegeuk Kim wrote: > On 10/25, Chao Yu wrote: >> On 2022/10/25 7:36, Jaegeuk Kim wrote: >>> The below commit disallows to set compression on empty created file which >>> has a inline_data. Let's fix it. >>> >>> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode conversion") >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/file.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>> index 1c4004c9245f..304fe08edc61 100644 >>> --- a/fs/f2fs/file.c >>> +++ b/fs/f2fs/file.c >>> @@ -1915,6 +1915,9 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >>> if (!f2fs_disable_compressed_file(inode)) >>> return -EINVAL; >>> } else { >>> + /* try to convert inline_data to support compression */ >>> + f2fs_convert_inline_inode(inode); >> >> It needs to check return value of f2fs_convert_inline_inode()? > > I intended to catch that in the below checks? But it may hide the real error number, e.g. -ENOMEM returned from f2fs_convert_inline_inode()? Thanks, > >> >> Thanks, >> >>> + >>> if (!f2fs_may_compress(inode)) >>> return -EINVAL; >>> if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))