mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Damien Le Moal <dlemoal@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>,
	agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	song@kernel.org, yukuai3@huawei.com, nilay@linux.ibm.com,
	axboe@kernel.dk, cem@kernel.org, dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-block@vger.kernel.org, ojaswin@linux.ibm.com,
	martin.petersen@oracle.com, akpm@linux-foundation.org,
	linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size
Date: Tue, 15 Jul 2025 17:45:28 +0200	[thread overview]
Message-ID: <0a33bc37-bb9e-4e70-afd8-59366d46b250@suse.de> (raw)
In-Reply-To: <20250714061300.GA13893@lst.de>

On 7/14/25 08:13, Christoph Hellwig wrote:
> On Mon, Jul 14, 2025 at 03:00:57PM +0900, Damien Le Moal wrote:
>> Agreed, it would be nice to clean that up. BUT, the chunk_sectors sysfs
>> attribute file is reporting the zone size today. Changing that may break
>> applications. So I am not sure if we can actually do that, unless the sysfs
>> interface is considered as "unstable" ?
> 
> Good point.  I don't think it is considered unstable.
>
Hmm. It does, but really the meaning of 'chunk_sectors' (ie a boundary 
which I/O requests may not cross) hasn't changed. And that's also
the original use-case for the mapping of zone size to chunk_sectors,
namely to ensure that the block layer generates valid I/O.
So from that standpoint I guess we can change it; in the end, there may
(and will) be setups where 'chunk_sectors' is smaller than the zone
size.
We would need to have another attribute for the zone size, though :-)
But arguably we should have that even if we don't follow the above
reasoning.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

  reply	other threads:[~2025-07-15 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  8:09 John Garry
2025-07-11  8:09 ` [PATCH v6 1/6] ilog2: add max_pow_of_two_factor() John Garry
2025-07-11  8:09 ` [PATCH v6 2/6] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-11  8:42   ` Damien Le Moal
2025-07-11  9:22     ` John Garry
2025-07-11  8:09 ` [PATCH v6 3/6] md/raid0: set chunk_sectors limit John Garry
2025-07-11  8:09 ` [PATCH v6 4/6] md/raid10: " John Garry
2025-07-11  8:09 ` [PATCH v6 5/6] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-11  8:09 ` [PATCH v6 6/6] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-07-11  8:44 ` [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size Damien Le Moal
2025-07-11  9:16   ` John Garry
2025-07-14  5:53   ` Christoph Hellwig
2025-07-14  6:00     ` Damien Le Moal
2025-07-14  6:13       ` Christoph Hellwig
2025-07-15 15:45         ` Hannes Reinecke [this message]
2025-07-14  7:52     ` John Garry
2025-07-14 10:46       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a33bc37-bb9e-4e70-afd8-59366d46b250@suse.de \
    --to=hare@suse.de \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®