From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@infradead.org>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"
Date: Fri, 19 Jun 2020 06:16:20 -0700 [thread overview]
Message-ID: <0a34e0d3-0035-7775-bd31-7dbdae9c968d@roeck-us.net> (raw)
In-Reply-To: <20200619074738.GB1427@infradead.org>
On 6/19/20 12:47 AM, Christoph Hellwig wrote:
> On Fri, Jun 19, 2020 at 01:48:23PM +0900, Masahiro Yamada wrote:
>> This reverts commit e0b250b57dcf403529081e5898a9de717f96b76b.
>>
>> Now that "make install" copies modules.builtin to $(INSTALL_MOD_PATH),
>> it breaks systems that do not set INSTALL_MOD_PATH for "make install".
>>
>> While modules.builtin is useful for CONFIG_MODULES=n, this way gives
>> unexpected impact to existing systems. Maybe "make modules_install"
>> can install modules.builtin irrespective of CONFIG_MODULES as Jonas
>> originally suggested. Anyway, this commit should be reverted ASAP.
>
> What is the "unexpected impact? This commit log needs to explain
> that.
>
$ make INSTALL_PATH=/tmp/destdir install
mkdir: cannot create directory ‘/lib/modules/5.8.0-rc1+/’: Permission denied
Makefile:1342: recipe for target '_builtin_inst_' failed
make: *** [_builtin_inst_] Error 1
Guenter
prev parent reply other threads:[~2020-06-19 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:48 Masahiro Yamada
2020-06-19 7:47 ` Christoph Hellwig
2020-06-19 13:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a34e0d3-0035-7775-bd31-7dbdae9c968d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dianders@chromium.org \
--cc=hch@infradead.org \
--cc=jonas@kwiboo.se \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®