From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Tzu-Ching Yang <shingekinocore@gmail.com>,
Eric Biggers <ebiggers@kernel.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Jose E. Marchesi" <jose.marchesi@oracle.com>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Simon Horman <horms@kernel.org>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] unroll: Make unrolled, unrolled_full and unrolled_none function-like
Date: Wed, 21 Oct 2026 17:02:30 +0200 [thread overview]
Message-ID: <0a38e0b0-2508-41c1-bd99-d15c27579307@intel.com> (raw)
In-Reply-To: <20261016025613.2690485-1-shingekinocore@gmail.com>
From: Tzu-Ching Yang <shingekinocore@gmail.com>
Date: Fri, 16 Oct 2026 10:56:13 +0800
> unrolled, unrolled_full and unrolled_none are object-like macros with
Because those are attributes. With function-like names such patterns:
unrolled()
for (int i = 0; i < n; i++)
are counter-intuitive and confusing.
We have either plain-named attributes like `notrace` (BTW what if you
name your variable as `notrace`?) or underscored like `__always_inline`.
If you really need to name your variables `unrolled`, then I'd expect
changing these macros to `__unrolled` etc, not to `unrolled()`.
Although I'm not sure we really need it, there's tons of such macros in
the kernel -- try naming your variable `current`.
> lower-case names, so in a file that includes <linux/unroll.h> every
> later identifier with one of these names is replaced with a _Pragma()
> operator. A local variable or struct member with one of these names
Thanks,
Olek
prev parent reply other threads:[~2026-10-21 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:56 Tzu-Ching Yang
2026-10-20 15:54 ` Eric Biggers
2026-10-21 15:02 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a38e0b0-2508-41c1-bd99-d15c27579307@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=horms@kernel.org \
--cc=jose.marchesi@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=shingekinocore@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®