From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
"'Dongjin Kim'" <Dongjin.Kim@agreeyamobility.net>
Cc: "'Dongjin Kim'" <tobetter@gmail.com>,
"'Russell King'" <linux@arm.linux.org.uk>,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: RE: 회신: [PATCH 2/4] arm/dts: exynos4: Add DTS files derived from common Exynos4
Date: Wed, 08 Aug 2012 11:08:54 +0900 [thread overview]
Message-ID: <0a3a01cd750a$c2e6a2b0$48b3e810$%kim@samsung.com> (raw)
In-Reply-To: <201208072029.08693.arnd@arndb.de>
Arnd Bergmann wrote:
>
> On Tuesday 07 August 2012, Dongjin Kim wrote:
> > Hi,
> >
> > I didn't use -M and I couldn't see any difference with the it.
> > Did I make something wrong on that patch?
>
> No, I think it's just git being less smart about file moves than I was
> hoping
> for. It might do the right thing if you do the patch in two steps:
>
Yeah, in this case, git does not work just as we expected :-(
> 1. rename exynos4210.dtsi to exynos4.dtsi and add a one-line
> exynos4210.dtsi
> file that just includes exynos4.dtsi.
>
> 2. do all the changes for moving contents back from exynos4.dtsi into
> exynos4210.dtsi and exynos4412.dtsi.
>
> Not sure if it's worth it though.
Hehehe, but I did with separated commit as per your comment and it was ok,
then squashed, same...uhm...I think, we don't need to keep two commits
here...
> Your version is probably good enough
> if there are no tools to do a better job automatically.
>
I agree with Arnd's opinion and I will review in detail soon.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-08-08 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 19:06 Dongjin Kim
2012-08-07 19:38 ` Arnd Bergmann
2012-08-07 19:57 ` 회신: " Dongjin Kim
2012-08-07 20:29 ` Arnd Bergmann
2012-08-08 2:08 ` Kukjin Kim [this message]
2012-08-08 3:38 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0a3a01cd750a$c2e6a2b0$48b3e810$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=Dongjin.Kim@agreeyamobility.net \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thomas.abraham@linaro.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®