mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Mark Brown <broonie@kernel.org>,
	Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Sven Frotscher <sven.frotscher@gmail.com>,
	git@augustwikerfors.se, alsa-devel@alsa-project.org,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v4] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
Date: Mon, 2 Oct 2023 08:47:21 -0500	[thread overview]
Message-ID: <0a3feafc-b843-420a-9b04-c835f8210c1a@amd.com> (raw)
In-Reply-To: <4fa7d39d-dc34-4550-97fa-2b089f364cca@sirena.org.uk>

On 10/2/2023 06:52, Mark Brown wrote:
> On Mon, Oct 02, 2023 at 11:32:48AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> 
>> Makes me wonder: How many more such quirk entries will be needed? Will
>> we have all machines listed soon, or do we expect that future Lenovo
>> hardware will need entries as well? If it's the latter: are quirks
>> really the right solution here, or do they just hide some bug or then
>> need for code that automatically handles things?
> 
> x86 firmware descriptions are terrible, it's just an endless procession
> of quirks.  The model for ACPI is not to describe key information in the
> kernel and instead on Windows load device specific information from
> separately supplied tables.  On Linux that translates into these endless
> quirks, on Windows it's platform specific drivers for otherwise generic
> audio hardware.

I knew there was a TON of "82" prefix systems from Lenovo so it was an 
educated guess that all of them needed DMIC support.  This was incorrect 
because one of them didn't have DMIC and that caused a no mic support 
problem on that system.

So in the case of this seemingly endless list of systems being added to 
enable DMIC support Mark is right, Windows does it differently.

With the "next" generation of hardware (Phoenix) both Windows and Linux 
*should* be using the same _DSD, so hopefully we don't need more quirks 
like this for those.

  parent reply	other threads:[~2023-10-02 13:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 22:36 Sven Frotscher
2023-10-02  9:32 ` Linux regression tracking (Thorsten Leemhuis)
2023-10-02 11:52   ` Mark Brown
2023-10-02 12:28     ` Linux regression tracking (Thorsten Leemhuis)
2023-10-02 12:54       ` Mark Brown
2023-10-02 13:00         ` Sven Frotscher
2023-10-02 13:04           ` Mark Brown
2023-10-02 13:17             ` Sven Frotscher
2023-10-02 13:47               ` Mark Brown
2023-10-02 13:47     ` Mario Limonciello [this message]
2023-10-02 14:13       ` Linux regression tracking (Thorsten Leemhuis)
2023-10-02 14:20         ` Mario Limonciello
2023-10-02 14:36           ` Linux regression tracking (Thorsten Leemhuis)
2023-10-02 14:40           ` Sven Frotscher
2023-10-02 18:51 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a3feafc-b843-420a-9b04-c835f8210c1a@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=git@augustwikerfors.se \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=sven.frotscher@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®