From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492311DFFD for ; Tue, 25 Jun 2024 07:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719301230; cv=none; b=NghkS+9Y6WTHm14ceznG3lL0wyevo/xZxo68uhnohWO7sxSL06fst1nsODHN2xtChoisDSMtplX9r+i6x/OBgaPKVtRpy5KX5dP795DrJPlYvvgFGjjGHeK3U8pRhd7Z8RbpMMoDInMhZCCwc0A/OJIl9wM3P1pPYEaOGC9p57M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719301230; c=relaxed/simple; bh=RP7RGrrDonDTYIDeuSRb++YyBdqPLC4y4FJuRa9Bxew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZqOE4DJOJVtuV//eNwG/ZE/BFDvq4eyjmZejPeMngxt8GFusAF4kUMLGdriIK6bW8iJoC5CMwpLJ/V45cRUHvlRmrCyKg7uULsBHOb4J7jtf8v6y2Y5nF8njJdAkwhfSV45VxGzPVPR/asptGK4hCwu7ID9lpyAS+XQCccpujew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Gj852HDm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gj852HDm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719301228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9+wXAkOghYPZA9aMx6dM9qgWvYyqbZycMi5G7med1Rs=; b=Gj852HDmahr5nC8eAHBZzL3jPY3m5SqYQX78KZOkWsT+CQ1l/i5cjW6rAN2jtHNHEv746L vJBDUQbx8CvX6J4WeBFzGsyvlxGauNzOlb5iuuplxXDll1q5w03fUXTp0t7G49bfzrziEV htdQNwYKYcXGmt4gD7T8wC5sHZ1jt7Q= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-5I8z7ieXPQa0S8bDgvgi-w-1; Tue, 25 Jun 2024 03:40:26 -0400 X-MC-Unique: 5I8z7ieXPQa0S8bDgvgi-w-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-52cd9f93fd8so2698238e87.0 for ; Tue, 25 Jun 2024 00:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719301225; x=1719906025; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9+wXAkOghYPZA9aMx6dM9qgWvYyqbZycMi5G7med1Rs=; b=sO3AT/LEN+7Mb8q/ZGx38FvE6CUKpW/WKDhLT+Gv3K5d0z8oaBn9dB8geeS0SkVcmO 4vKgRfZbVv05+wXkqtC6u+V3JqBrp23zb9o7v27WGkgaTWDEvUvnZVrr4ICJBrSRFV0i +UVt9jDLgaFgbNfIWXAbD42myl0DyM1rUjjCKGQYJ5Z1SvgBVOEQNQUL09BDtOsXnv2d x0iJ93eDKn5/WT2LqNbCQCH0F9GjZPrSy9iS/sVzzkW2+5n37FWANduSHrf2QQh6HTmQ /czNlNKKQM1UJcSd6BB5Fa/jz5HGLLDGwPatlSEEnFKJ6uRgNtn9z34gBToQC49Ho7Ai hNzw== X-Forwarded-Encrypted: i=1; AJvYcCW20FX40OCS0QItl3SvxuaXu7up4Aknke1KDGCg67Ny49jnJCprVsrUU7NLO+LjmYt9RgtDRoeCSbWXUg+e71PVl8ML7L0bk7fwmSwy X-Gm-Message-State: AOJu0Yx50bbtkXNivl73FYDat88d2pNQCXWzTQNypFVICWbGMb82bdWr 9sTiLsmZHdlnhk/cA+p1WDRGwbXDFATPXGZMxnR9Xqb2541TMbq/tTz7sBqLmPQMji4gUwsUunE CuP3wTY+5w5+QPe/u3rDKeoq1fvSyntNpyIZ8GD956tm20xWt/qkw6Sm865ItFA== X-Received: by 2002:a05:6512:2353:b0:52c:d20b:22c8 with SMTP id 2adb3069b0e04-52ce186172dmr5809895e87.64.1719301224776; Tue, 25 Jun 2024 00:40:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXZutTW6hXLPjHJBKTNDbaTOsN2HKSw8f0cmAYj/4DUacmPqzWzk8vauOyA2mTLnJmTsWvcQ== X-Received: by 2002:a05:6512:2353:b0:52c:d20b:22c8 with SMTP id 2adb3069b0e04-52ce186172dmr5809867e87.64.1719301224308; Tue, 25 Jun 2024 00:40:24 -0700 (PDT) Received: from [192.168.1.34] (p548825e3.dip0.t-ipconnect.de. [84.136.37.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817b6121sm161058115e9.27.2024.06.25.00.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 00:40:23 -0700 (PDT) Message-ID: <0a41d5fc-d1a1-4b1b-873e-a701b20bbcb3@redhat.com> Date: Tue, 25 Jun 2024 09:40:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable] mm: folio_add_new_anon_rmap() careful __folio_set_swapbacked() To: Hugh Dickins , Andrew Morton Cc: Barry Song <21cnbao@gmail.com>, baolin.wang@linux.alibaba.com, chrisl@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuanshuai@oppo.com, yuzhao@google.com References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.06.24 07:00, Hugh Dickins wrote: > Commit "mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)== > false" has extended folio_add_new_anon_rmap() to use on non-exclusive > folios, already visible to others in swap cache and on LRU. > > That renders its non-atomic __folio_set_swapbacked() unsafe: it risks > overwriting concurrent atomic operations on folio->flags, losing bits > added or restoring bits cleared. Since it's only used in this risky > way when folio_test_locked and !folio_test_anon, many such races are > excluded; but, for example, isolations by folio_test_clear_lru() are > vulnerable, and setting or clearing active. > > It could just use the atomic folio_set_swapbacked(); but this function > does try to avoid atomics where it can, so use a branch instead: just > avoid setting swapbacked when it is already set, that is good enough. > (Swapbacked is normally stable once set: lazyfree can undo it, but > only later, when found anon in a page table.) > > This fixes a lot of instability under compaction and swapping loads: > assorted "Bad page"s, VM_BUG_ON_FOLIO()s, apparently even page double > frees - though I've not worked out what races could lead to the latter. > > Signed-off-by: Hugh Dickins > --- > mm/rmap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index df1a43295c85..5394c1178bf1 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1408,7 +1408,9 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, > VM_WARN_ON_FOLIO(folio_test_hugetlb(folio), folio); > VM_BUG_ON_VMA(address < vma->vm_start || > address + (nr << PAGE_SHIFT) > vma->vm_end, vma); > - __folio_set_swapbacked(folio); > + > + if (!folio_test_swapbacked(folio)) > + __folio_set_swapbacked(folio); > __folio_set_anon(folio, vma, address, exclusive); > > if (likely(!folio_test_large(folio))) { LGTM. I'll point out that it's sufficient for a PFN walker to do a tryget + trylock to cause trouble. Fortunately isolate_movable_page() will check __folio_test_movable() before doing the trylock. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb