mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "jkardatzke@google.com" <jkardatzke@google.com>,
	"nicolas@ndufresne.ca" <nicolas@ndufresne.ca>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
	"christian.koenig@amd.com" <christian.koenig@amd.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag
Date: Wed, 17 Apr 2024 08:41:44 +0000	[thread overview]
Message-ID: <0a4211070f1c895d776e3d9dee9ae3113de8c976.camel@mediatek.com> (raw)
In-Reply-To: <CA+ddPcMWein69X6U46pZbDy51gFHHxXV5d+6BvFq7ma6n0E22w@mail.gmail.com>

On Tue, 2024-04-16 at 10:19 -0700, Jeffrey Kardatzke wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  I would argue 'restricted' is the proper name since that was what
> was
> settled on for the dma-buf code.  :)  But you are definitely right
> that this memory is not encrypted.
> 
> 
> On Tue, Apr 16, 2024 at 7:09 AM Nicolas Dufresne <
> nicolas@ndufresne.ca> wrote:
> >
> > Hi,
> >
> > Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit :
> > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > >
> > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate
> >
> > Is "ENCRYPTED" a proper naming ? My expectation is that this would
> hold data in
> > a PROTECTED memory region but that no cryptographic algorithm will
> be involved.
> >
> > Nicolas
> >
> > > a secure buffer to support secure video path feature.
> > >
> > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> > > ---
> > >  include/uapi/drm/mediatek_drm.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/uapi/drm/mediatek_drm.h
> b/include/uapi/drm/mediatek_drm.h
> > > index b0dea00bacbc4..e9125de3a24ad 100644
> > > --- a/include/uapi/drm/mediatek_drm.h
> > > +++ b/include/uapi/drm/mediatek_drm.h
> > > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off {
> > >
> > >  #define DRM_MTK_GEM_CREATE           0x00
> > >  #define DRM_MTK_GEM_MAP_OFFSET               0x01
> > > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02

OK, I'll change this to DRM_MTK_GEM_CREATE_RESTRICTED at the next
version.

Regards,
Jason-JH.Lin

> > >
> > >  #define DRM_IOCTL_MTK_GEM_CREATE     DRM_IOWR(DRM_COMMAND_BASE +
> \
> > >               DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create)
> >
> >

  reply	other threads:[~2024-04-17  8:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 10:26 [PATCH v5 0/9] Add mediate-drm secure flow for SVP Shawn Sung
2024-04-03 10:26 ` [PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag Shawn Sung
2024-04-15  9:32   ` Maxime Ripard
2024-04-17  8:36     ` Jason-JH Lin (林睿祥)
2024-04-16 14:09   ` Nicolas Dufresne
2024-04-16 17:19     ` Jeffrey Kardatzke
2024-04-17  8:41       ` Jason-JH Lin (林睿祥) [this message]
2024-04-03 10:26 ` [PATCH v5 2/9] drm/mediatek: Add secure buffer control flow to mtk_drm_gem Shawn Sung
2024-04-15  9:37   ` Maxime Ripard
2024-05-28  7:06     ` Jason-JH Lin (林睿祥)
2024-04-03 10:26 ` [PATCH v5 3/9] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane Shawn Sung
2024-04-03 10:26 ` [PATCH v5 4/9] drm/mediatek: Add mtk_ddp_sec_write to config secure buffer info Shawn Sung
2024-04-03 10:26 ` [PATCH v5 5/9] drm/mediatek: Add get_sec_port interface to mtk_ddp_comp Shawn Sung
2024-04-03 10:26 ` [PATCH v5 6/9] drm/mediatek: Add secure layer config support for ovl Shawn Sung
2024-04-03 10:26 ` [PATCH v5 7/9] drm/mediatek: Add secure layer config support for ovl_adaptor Shawn Sung
2024-04-03 10:27 ` [PATCH v5 8/9] drm/mediatek: Add secure flow support to mediatek-drm Shawn Sung
2024-04-03 10:27 ` [PATCH v5 9/9] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize Shawn Sung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a4211070f1c895d776e3d9dee9ae3113de8c976.camel@mediatek.com \
    --to=jason-jh.lin@mediatek.com \
    --cc=Shawn.Sung@mediatek.com \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=christian.koenig@amd.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jkardatzke@google.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=sumit.semwal@linaro.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®