From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CE6C4332F for ; Mon, 12 Dec 2022 09:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbiLLJJG (ORCPT ); Mon, 12 Dec 2022 04:09:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbiLLJIz (ORCPT ); Mon, 12 Dec 2022 04:08:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D35DD2; Mon, 12 Dec 2022 01:08:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65A42B80A4A; Mon, 12 Dec 2022 09:08:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63287C433EF; Mon, 12 Dec 2022 09:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670836132; bh=+syCpe53ksZ1wk/P+ti6joXMTLfEgJsQad42fqKxD3g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NSC7eTO0arSVlDUtvmnWkmHX8oKugfq1mHlKbrZuU/v1ILMrnZ5E++3Mpa3Hc9fuI /dbB8VZSGb89vmfi9DfHkC7EIhEetA5vvbQZHdCUkC87ddQhd9pGHa3mboMXsTysOT XgPzcRlO2WqYieGyv8jZJPL0XcnZvcsbsW1kOW9YzOOh4zRXk/Nah0HMLxTuu/0Txo Tgv41hTvIY0aMCYyHr+NC0xyLlO4UwtIn2ZZlXbBWP/Kbb/KEwP2Su2GoCcXASjuLN 9B2UNexqwTGaca0T3dLRP3M4sf8XPFryN/rdmEOBaFZ7EoaWikTcpAFikcBpcoEUte KfpjN9KykJUEg== Message-ID: <0a42d725-ce95-216f-6078-877590be1d09@kernel.org> Date: Mon, 12 Dec 2022 11:08:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] memory: omap-gpmc: fix wait pin validation Content-Language: en-US To: "B. Niedermayr" , linux-next@vger.kernel.org, Tony Lindgren , Krzysztof Kozlowski Cc: Rob Herring , "open list:OMAP GENERAL PURPOSE MEMORY CONTROLLER SUPPORT" , "open list:MEMORY CONTROLLER DRIVERS" References: <20221209123147.591982-1-benedikt.niedermayr@siemens.com> From: Roger Quadros In-Reply-To: <20221209123147.591982-1-benedikt.niedermayr@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2022 14:31, B. Niedermayr wrote: > From: Benedikt Niedermayr > > This bug has been introduced after switching from -1 to UINT_MAX > for GPMC_WAITPIN_INVALID. > > The bug leads to an error when the optional gpmc,wait-pin > dt-property is not used: > > ... > gpmc_cs_program_settings: invalid wait-pin (-1) > ... > > Signed-off-by: Benedikt Niedermayr > Fixes: 8dd7e4af5853 ("memory: omap-gpmc: fix coverity issue "Control flow issues"") > Cc: Rob Herring Acked-by: Roger Quadros