From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51EBE1DED63 for ; Mon, 15 Dec 2025 11:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765797653; cv=none; b=qVuEqUtV934S+KlLmYRe/B7WdyURKTbLGv+HnZyY2VYvATX8bePhWYh1jtv+GRSF9QFHNbFOOXtS5j14PwYm0SbuklEvHrGsQecZaDD+IpI14gGQ35Dr6btp9eHwfnZ8D7uKjrTUn4HtCAB6JysFXPdHDE2Tt1G/UOxTSSK8ODg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765797653; c=relaxed/simple; bh=yasU4dzPPWpKkUuf+d4UADJ4/QOM7Qe9QYXueO46i/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EDqC+wj4Vp055ih5F6dN4XoHBRmLco/PwcwdmgVz3JujemRlRNYaJ4/tiuCxiuAhl+wwTvzql9eSiKUumFn0n+ugWQg/d70GTdXPw9nY+KwFfDxHMFWQOwqZ+8his7yzc9CWQ9SIOD97cFencnavyF4uOH4z5udrs/gMfk4UEy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h9Xh8+Vs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fq8ghNaW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h9Xh8+Vs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fq8ghNaW" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BFANpJD436231 for ; Mon, 15 Dec 2025 11:20:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3GUwtPTD7pgS0FJUQOfGGk2o/7cX2hY9/PZpPqLYeA4=; b=h9Xh8+VscOSW/yL7 Norz99U6zZ30GI5+qn1RaoGOnn38BI/FD0XU2MeQeuPhbxa5sZ85vBowpMz3e//7 1gzgsDMFxpjwI04lHQiCCiEmOhSgjb83acyqiFGRU8Vj0aCQBDHTUfXcRosG5blc 8UHNw/YRubduIiACvzGuXJR5UyVuDY+ie44bUvIv/ejfXeFOkFdfWiFklbpC88PH hqaGVxAsudqiGPTXmjOdTRBGh9roqCgQTVHkW0DLLtyG2Y6mDPy+5xJcqdnLLjpc 3P6sbnLmvWubVUnxgnf+MhjAgJS2HVbLSUnNN1H4Bwu9ouOq5jErW/fzenRzSQgt xEBM1w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b119amc38-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Dec 2025 11:20:45 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7d481452732so5947094b3a.1 for ; Mon, 15 Dec 2025 03:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765797645; x=1766402445; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3GUwtPTD7pgS0FJUQOfGGk2o/7cX2hY9/PZpPqLYeA4=; b=fq8ghNaWGOoQXeFHoY+mBbUUtjNE5W8F9eLj+bsHGNisOkNL8m8o5d5MIyp3poz1Oa WvDdUcMgm0+Cc10QRGBVHt7QiRcaMtuMx5hPh9kYQgcv20b/ra616tloY4nT7rBEjV/W mwJK3ClJcQoZaDnUp3RxAlhsqL9cKtKykXfQioNqa0mpgj5IeoFoP/nX0vQEfLkhKTYP nAFnHU98dsm6je6MecDW9ltZWTzNb3/TzpuXXYMKXWzMorJQm6H7PPz+zlQmzclCj89Z Au8asMdjsani/4ij7CDCASMi0Wz5OvGKQR+qOuAnv1vMty1sNUTubeq1uld8bdHnlpSn zahQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765797645; x=1766402445; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3GUwtPTD7pgS0FJUQOfGGk2o/7cX2hY9/PZpPqLYeA4=; b=UAh9b3U5Sz6627HXbDA84+DPS86AkcZzf6UKsENZefGDPiB8hx7gzsdi08P2UuuAdn kIpiIXn+YrUIZDxFI3tmR41m5yJYtr7tZw+hdgzfzvwJkswBtRm78/XyM4rzvaPV5RgM EnQFHd3CCiwl0hwCK3YH038YWfA7x/XmL1B+b4BFJHwiFc3PDwrOFtOY5cdDMUhHnLH4 HOrtXvtfT6eLdEN6wPMMGVrtioFZ/ki0xAaIdeVv8y0FUITvRNv9Z194T22RFP6lrsoX D63VIkyYvCyT5RAp9itEXnNT4KZD4szuW+SXx/60z6K+FaaZLU4WoOZxnP5YgiUEIj7G OL/w== X-Forwarded-Encrypted: i=1; AJvYcCVy9P8YpUzc+bl+H+gxGo70d5u4WakhSbqR0RoPxL4B+XHzz5+PX7RxX+QXSY8UPZNfWjxvQMe/do3Ct70=@vger.kernel.org X-Gm-Message-State: AOJu0YzcsUOpJhpiKgRYzRIgoPd0YEUXFa4rtY5pNM3dNIjud41dL2VG tEk5RhpJW2v9F4H1FbK/W/GIrrELTfl3wNu3CHOQNwV4GG2CVbPZZnTsUXvm0jdl8SA8pZwfRnS tjUW7Ncl+17eVQGYWMHgb9wgGyNVAB/PHQuncU6GBSDuEl+DQw3Yrr9KYbUk93ZI1Gbc= X-Gm-Gg: AY/fxX7x0nEsYfa7EIi6pTbbz928WY/4sbxJ7cUNcMou90bg4kZ35CbRRY1eGmI0Q8N p0oQA67yTwXXxsLU/btKQSg4U4QRaNEVAvvY5LTtTBoUBYUdCKiEEFCIPu2VJuwctBYIdnT7ixi Yfd4u/5Q7JAHtk/I7rJUeyOBJXJA2pqMOBPlUdOYX01X1u4JtE2Y5ZNXqfrbx1mVJl85DD8csr7 tIJMTwwXs7k4CysBRHXov3Gbof+sa+IQj+EjIcE3HK8JsT59wAjA5gK+AVD/yKm8N8Cf7jF4DeT jUCH/cdKBOMEPcThgLD1z6BlPchKzB/spaHsSx52goBUUzoIyM3nNWpFGbju9w002jZwWM9GxNf M9zed3iqZzB9jOiZbGgpy0hYehqhJZUox+W9rWnc= X-Received: by 2002:a05:6a00:8683:b0:7e8:450c:61b5 with SMTP id d2e1a72fcca58-7f67156b796mr5756154b3a.37.1765797644753; Mon, 15 Dec 2025 03:20:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAa6RaseztafsU6ZzwG5ohOvRVQ0hzB8/6C439lWKD+y8Q05aOqhKVyudkKjzVXkz3SgfaFg== X-Received: by 2002:a05:6a00:8683:b0:7e8:450c:61b5 with SMTP id d2e1a72fcca58-7f67156b796mr5756131b3a.37.1765797644225; Mon, 15 Dec 2025 03:20:44 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c4aa9b56sm12393296b3a.39.2025.12.15.03.20.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 03:20:43 -0800 (PST) Message-ID: <0a4368bf-40a2-42bb-b538-6e64c11598e3@oss.qualcomm.com> Date: Mon, 15 Dec 2025 16:50:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: defconfig: Enable QCOMTEE on Qualcomm SM8650+ To: Sumit Garg , Bjorn Andersson , Dmitry Baryshkov , Krzysztof Kozlowski Cc: Konrad Dybcio , Jens Wiklander , Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20251208-qcom_qcomtee_defconfig-v3-1-b50dcf8ab45e@oss.qualcomm.com> <309e0391-58a3-466b-a113-ab864188f6fe@kernel.org> <05581cbd-dfcc-41ac-9020-b1590b8ed7a8@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE1MDA5NyBTYWx0ZWRfX4mLa4Ko0LH0V XZqYoQgqhkyXlrqQ/6T787fZEdKTdWJeP2gZa+gKFzwpafIahlgeJ+dkdqT/7w5eiWafaCR55ip D2BB6QhVXhGGXvIJiUN2qUItyobPBr1NOwwv5KeKwmkNbeDyE8NQfcdGwmMzGbsjXZEhFrbftXJ sqWMxbmgnEtSxEJu6aHvAnJaFH3D7+zvX8PWoVloLQKCOL+ucuvxBGaoPB9KbccR4xY/bp9nP3k 9B29rVqj6KZelVAsGhbS0KdrKdGDuFHmRXz35deZOX67kh0JFLCDg8nKNTXjuNa/WgN5QKf3iO5 6Y4uY/CnwggY/04k901UoCHdKDa9wJYYCjDXVCmAT+EExZp2Bbh/RBJDqaYhGcuTuQRIVAnTvXj khjEG648a5k5RLeEcmSRzuQI3g9JjA== X-Authority-Analysis: v=2.4 cv=LNFrgZW9 c=1 sm=1 tr=0 ts=693fef0d cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NEAV23lmAAAA:8 a=elEROV__wQne4N9O37AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: 1svqTcIgRR25n6NGY1UhNsXvRZFdz2vS X-Proofpoint-ORIG-GUID: 1svqTcIgRR25n6NGY1UhNsXvRZFdz2vS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_02,2025-12-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512150097 Hi all, On 12/12/2025 6:55 AM, Sumit Garg wrote: > On Wed, Dec 10, 2025 at 02:35:19PM +0530, Harshal Dev wrote: >> Hi Bjorn, >> >> On 12/10/2025 9:21 AM, Bjorn Andersson wrote: >>> On Mon, Dec 8, 2025 at 10:14 PM Dmitry Baryshkov >>> wrote: >>>> On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski wrote: >>>>> >>>>> On 08/12/2025 13:18, Harshal Dev wrote: >>>>>> Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication >>>>>> with the Qualcomm Trusted Execution Environment (QTEE). >>>>>> (No enablement required in DTS files since QCOMTEE device is dynamically >>>>>> registered by the QCOM_SCM firmware driver) >>>>>> >>>>>> Signed-off-by: Harshal Dev >>>>>> --- >>>>>> Changes in v3: >>>>>> - Updated the commit message to reflect the supported Qualcomm platforms. >>>>>> - Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@qti.qualcomm.com >>>>>> >>>>> >>>>> I gave you the exact example to follow. Maybe it is not that important >>>>> for others, so I will not object, but OTOH it is important for me, thus >>>>> I will not give reviewed by. I damn asked VERY CLEARLY: >>>>> >>>>> "Just mention which UPSTREAM boards (which you called Qualcomm >>>>> platforms) use this driver." >>>> >>>> +1 Here. Defconfig changes mention devices, not SoC families. >>>> >>> >>> I don't agree that you have to mention a specific board, if the >>> feature is used by all boards. But I think the commit message should >>> make _that_ clear. >>> >> >> Thanks for this input Bjorn. I gather we are now aligned that the board >> information is not required. >> >> Then the other part to this is how to provide information on the particular >> SoCs using this. >> >>> On the contrary, the commit message says that we're enabling >>> CONFIG_QCOMTEE because it's used on "SM8560+". What does the plus >>> mean? >> >> I took reference from similar commits merged earlier where the plus seemed >> to indicate that all Qualcomm SoCs from 'SM8650' on-wards, that is, SM8750, >> SM8850 and so on. It felt that the plus sign is self-explanatory since it >> has been used already. But sure, maybe we can be explicit from now on and say >> from 'Qualcomm SM8650 onwards'. >> >> commit c5d02bbaa217b2454ba1ce7528113aa2ecf14f3c >> >>> Also, the driver isn't enabled "on Qualcomm SM8650+", it's enabled in >>> the Am64 defconfig, i.e. it's enabled on all Arm64 boards - the >>> question that should be answered by the commit message is "why?". >>> >> >> Even though we are enabling this via the arm64 defconfig, it is not true that >> the driver is applicable for all arm64 boards. The simple reason being that >> the QTEE firmware OS that the driver communicates with runs only on Qualcomm >> SoCs using arm64 CPUs with ARM TrustZone technology. >> >> This is why I would try to avoid a commit message which claims the the driver >> is applicable to all arm64 boards. >> >> Based on all this, I am thinking perhaps it would be better to say that the >> patch enables QCOMTEE driver for Qualcomm SoCs with arm64 CPUs? We could drop >> mentions of specific SM8x50 models with HDK/MTP boards since the feature is >> agnostic to those? > > AFAIK, the QCOMTEE driver works on the Qcom SoCs based on arm64 which supports > the SMCInvoke protocol. So we should be explicit about it. Regarding > mention of reference publicly available boards, I can see how it can be useful > for the community to test QTEE based apps. If you can mention say > example RB3Gen2 supports QTEE driver at least then it will be helpful. > Based on consolidated feedback on this thread, I am thinking of the following commit message, let me know if this is a go from everyone's perspective: " arm64: defconfig: Enable QCOMTEE for Qualcomm SoCs using arm64 CPUs Enable QCOMTEE driver as a module for Qualcomm SoCs based on arm64 CPUs and supporting the SMCInvoke protocol for communication with the Qualcomm Trusted Execution Environment (QTEE). The driver is tested on a Qualcomm RB3Gen2 board by loading and executing a Trusted Application via tests hosted at www.github.com/qualcomm/minkipc. " Regards, Harshal > -Sumit > > [...]