mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Arthur Simchaev <Arthur.Simchaev@wdc.com>,
	martin.petersen@oracle.com
Cc: beanhuo@micron.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] ufs: core: Remove redundant wb check
Date: Thu, 8 Dec 2022 13:22:15 +0100	[thread overview]
Message-ID: <0a44763d-8c40-b9e7-6268-01567c401884@gmail.com> (raw)
In-Reply-To: <b89f3337-0869-35a8-114d-85e1fd81eb2c@acm.org>


On 08.12.22 12:31 AM, Bart Van Assche wrote:
> On 11/27/22 04:08, Arthur Simchaev wrote:
>> We used to use the extended-feature field in the device descriptor,
>> as an indication that the device supports ufs2.2 or later.
>> Remove that as this check is specifically done few lines above.
>>
>> Reviewed-by: Bean Huo <beanhuo@micron.com>
>> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
>> ---
>>   drivers/ufs/core/ufshcd.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
>> index 2dbe249..2e47c69 100644
>> --- a/drivers/ufs/core/ufshcd.c
>> +++ b/drivers/ufs/core/ufshcd.c
>> @@ -7608,10 +7608,6 @@ static void ufshcd_wb_probe(struct ufs_hba 
>> *hba, const u8 *desc_buf)
>>            (hba->dev_quirks & 
>> UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES)))
>>           goto wb_disabled;
>>   -    if (hba->desc_size[QUERY_DESC_IDN_DEVICE] <
>> -        DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
>> -        goto wb_disabled;
>> -
>>       ext_ufs_feature = get_unaligned_be32(desc_buf +
>>                       DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
>
> Does this code really have to be removed? I see a check of the
> UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES flag above the removed
> code but no check of the descriptor size?
>
it is not necessary to check this, but if you have concern, we could 
change to like this:


         if (desc_buf[DEVICE_DESC_PARAM_LEN] <
             DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
                 goto wb_disabled;

then   hba->desc_size could be removed.

Kind regards,

Bean




  reply	other threads:[~2022-12-08 12:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27 12:08 [PATCH v4 0/4] ufs: core: Always read the descriptors with max length Arthur Simchaev
2022-11-27 12:08 ` [PATCH v4 1/4] ufs: core: Remove redundant wb check Arthur Simchaev
2022-12-07 23:31   ` Bart Van Assche
2022-12-08 12:22     ` Bean Huo [this message]
2022-12-08 17:28       ` Bart Van Assche
2022-12-08 17:29   ` Bart Van Assche
2022-11-27 12:08 ` [PATCH v4 2/4] ufs: core: Remove redundant desc_size variable from hba Arthur Simchaev
2022-12-07 23:36   ` Bart Van Assche
2022-12-08 12:48     ` Arthur Simchaev
2022-11-27 12:08 ` [PATCH v4 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl Arthur Simchaev
2022-12-07 23:48   ` Bart Van Assche
2022-11-27 12:08 ` [PATCH v4 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length function Arthur Simchaev
2022-12-07 23:52   ` Bart Van Assche
2022-12-04 13:22 ` [PATCH v4 0/4] ufs: core: Always read the descriptors with max length Arthur Simchaev
2022-12-07  3:48   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a44763d-8c40-b9e7-6268-01567c401884@gmail.com \
    --to=huobean@gmail.com \
    --cc=Arthur.Simchaev@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®