From: Jie Deng <Jie.Deng1@synopsys.com>
To: Alexandre Torgue <alexandre.torgue@st.com>,
Jie Deng <Jie.Deng1@synopsys.com>, <davem@davemloft.net>,
<f.fainelli@gmail.com>, <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <CARLOS.PALMINHA@synopsys.com>,
<lars.persson@axis.com>, <thomas.lendacky@amd.com>,
<peppe.cavallaro@st.com>, <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC
Date: Fri, 9 Dec 2016 12:47:36 +0800 [thread overview]
Message-ID: <0a46d57e-dd24-6397-5a0c-a8534aa94d20@synopsys.com> (raw)
In-Reply-To: <92a2dbaf-00be-bded-aa75-4c920db4a204@st.com>
On 2016/12/8 23:59, Alexandre Torgue wrote:
> Hi
>
> On 12/07/2016 04:57 AM, Jie Deng wrote:
>> This series provides the support for 25/40/50/100 GbE
>> devices using Synopsys DWC Enterprise Ethernet (XLGMAC).
>
> Can you explain which GMAC are you targeted ?
>
> A driver which support some Synopsys GMAC IP already exists. It support GMAC
> 3.5, 3.7, 4.0, 4.10 versions. You can find it in:
> drivers/net/ethernet/stmicro/stmmac/. When I look at all files your gonna to
> create, it looks like to ones in stmmac driver so maybe you could easily add
> your IP inside stmmac driver.
>
> Note that an other driver is existing for synopsys GMAC 4.0 IP. it is located
> in drivers/net/ethernet/synopsys/dwc_eth_qos.c and coming from AXIS guys. A
> task is ongoing to only have stmmac driver so it should be harmful to create a
> new one.
>
> Regards
> Alex
>
I didn't target any version of GMAC IP. GMAC IP (QoS IP) currently has two
drivers in mainline
drivers/net/ethernet/synopsys/dwc_eth_qos.c
drivers/net/ethernet/stmicro/stmmac/
XGMAC IP: drivers/net/ethernet/amd/xgbe
XLGMAC IP: no driver in mainline at present
For more info about Synopsys Ethernet IP, Please check:
http://www.synopsys.com/IP/InterfaceIP/Ethernet/Pages/default.aspx
I think it should be better to integrate above drivers into
drivers/net/ethernet/synopsys/. This helps to reuse codes and makes maintenance
easier. I prefer to choose AMD XGBE as a basis. This driver integrated Synopsys
internal driver and had most features supported. What do you think about this ?
>
>
>
>>
>> The first patch adds support for Synopsys XLGMII.
>> The second patch provides the initial driver for Synopsys XLGMAC
>>
>> The driver has three layers by refactoring AMD XGBE.
>>
>> dwc-eth-xxx.x
>> The DWC ethernet core layer (DWC ECL). This layer contains codes
>> can be shared by different DWC series ethernet cores
>>
>> dwc-xxx.x (e.g. dwc-xlgmac.c)
>> The DWC MAC HW adapter layer (DWC MHAL). This layer contains
>> special support for a specific MAC. e.g. currently, XLGMAC.
>>
>> xxx-xxx-pci.c xxx-xxx-plat.c (e.g. dwc-xlgmac-pci.c)
>> The glue adapter layer (GAL). Vendors who adopt Synopsys Etherent
>> cores can develop a glue driver for their platform.
>>
>> Jie Deng (2):
>> net: phy: add extension of phy-mode for XLGMII
>> net: ethernet: Initial driver for Synopsys DWC XLGMAC
>>
>> Documentation/devicetree/bindings/net/ethernet.txt | 1 +
>> MAINTAINERS | 6 +
>> drivers/net/ethernet/synopsys/Kconfig | 2 +
>> drivers/net/ethernet/synopsys/Makefile | 1 +
>> drivers/net/ethernet/synopsys/dwc/Kconfig | 37 +
>> drivers/net/ethernet/synopsys/dwc/Makefile | 9 +
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c | 228 ++
>> .../net/ethernet/synopsys/dwc/dwc-eth-debugfs.c | 328 +++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c | 715 +++++
>> .../net/ethernet/synopsys/dwc/dwc-eth-ethtool.c | 567 ++++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c | 3098 ++++++++++++++++++++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c | 252 ++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c | 2319 +++++++++++++++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c | 216 ++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h | 1115 +++++++
>> drivers/net/ethernet/synopsys/dwc/dwc-eth.h | 738 +++++
>> drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c | 538 ++++
>> drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c | 135 +
>> drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h | 85 +
>> include/linux/phy.h | 3 +
>> 20 files changed, 10393 insertions(+)
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/Kconfig
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/Makefile
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-debugfs.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ethtool.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth.h
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c
>> create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h
>>
next prev parent reply other threads:[~2016-12-09 4:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 3:57 Jie Deng
2016-12-07 3:57 ` [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII Jie Deng
2016-12-08 22:15 ` Florian Fainelli
2016-12-09 5:19 ` Jie Deng
2016-12-09 16:39 ` Andrew Lunn
2016-12-10 2:16 ` Jie Deng
2016-12-07 3:57 ` [PATCH net-next 2/2] net: ethernet: Initial driver for Synopsys DWC XLGMAC Jie Deng
2016-12-07 9:48 ` Pavel Machek
[not found] ` <bea5ea07-cbab-35fe-434c-1cfcb96225ef@synopsys.com>
2016-12-08 21:57 ` Pavel Machek
2016-12-12 8:26 ` kbuild test robot
2016-12-08 15:59 ` [PATCH net-next 0/2] " Alexandre Torgue
2016-12-09 4:47 ` Jie Deng [this message]
2016-12-09 15:15 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a46d57e-dd24-6397-5a0c-a8534aa94d20@synopsys.com \
--to=jie.deng1@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®