From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E790398917 for ; Tue, 7 Apr 2026 08:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550814; cv=none; b=spAf2SYP2Rgj+GqR40KOeeYHt4gifF2SBp/8//p30vJapAz+8ks/ibKGyUxjj+xGdooySwRYLouUDJa/yArwFO5TS5IYh2JbcYVuJ7AEc9un0ZIwiEfkDLTwsue4g+UCEwQC7ry8Yq9Evq9b+PAfVBa/KlpsZ3alhbcFMlC51vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550814; c=relaxed/simple; bh=t55foggjJ9sSeJoYrckqwiZ5xeOlFzCMrKhSktRG//o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wu6wYUzhxv8kek8CX99cH2aWDv82HsFZ23rJHvyBR71WlvCNQ71hLzZsBGhW0tSYparuBS7Q1SrpUJBScnOoI4UHLNGeiIxUPY++2NpjQ7gZJRQcqalNtUe9c/TwCOcwzUjPU8oML38qOIowxOcAKNUMJsuZnjmY/pIDnlr8RM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ODmahafT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G0Ux9JtD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ODmahafT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G0Ux9JtD" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376OOcZ3536831 for ; Tue, 7 Apr 2026 08:33:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4kSshX4uGfYBdsUzyeF3oIoRRsOk5V44gKiKit90pj8=; b=ODmahafT0X8Kok4l JDDnqwm9Z1QwvJkxLoLupmOVTP1dHgHqiBuGvgoQACBZ8jpaJomVaHSEVaTjODzs UZIFCwBGypyGEmiGs19ibXI4OOuehJosL4IkYiQxCr4WrczUNB/rONrJ2EFeKNpL 94mXiEVs05PunpoWP/mWVGCHtwAQVUfgE6RnLo5QwBJukFHjYGhQ7ILw4iUahVCF sy5S+pvRMvBancjo7G3ox1//5qS9Hy5Vp7adZdwzkUHpTPStUPszF5fMvnG4det/ dc3ur7uUlK1CtHpjnVDlgfIviJZRKHYRjywmgayGdurQxmIRTJQnsWCSq6SFLJKk 8j4s0w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmra1unm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 08:33:28 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3595485abbbso5788643a91.2 for ; Tue, 07 Apr 2026 01:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775550808; x=1776155608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4kSshX4uGfYBdsUzyeF3oIoRRsOk5V44gKiKit90pj8=; b=G0Ux9JtDGRbFBNeauM778qdMLMRK+p4s/1AltbCaW0b2cAp8Wmn9OohtIRoorRjz8z M4ywXXr1IKBIleaFaE0PliU2u9kdDMbop1XGmX0AJGop3jexjehwwpeuF5U7IWXrX4LG wwRBOyQFpWR17M4V1A61VeY+5mPoi3ZV/HYxRNS+t2dzgPN6UXi9djRveX+E/fIxd5bu AJwpo7cKps/TH3G0N3LDvMqMbtTAQSq+k67c5idt1LLH/oI1o/gI5aKxRL/dSeHBBNDX g3Y+JeMuwI6d4O+eKBS37vP0fX4LAnAj1stJY7RWalhm2DmX9GQUw+JfRst+UwRT+Z6B j5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775550808; x=1776155608; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4kSshX4uGfYBdsUzyeF3oIoRRsOk5V44gKiKit90pj8=; b=dylDlQdrXzoAeD5sEFJoRdKsiahyMnz3oMxgLvt6Jj1n+ybKlefPFyC46tmTMmMC8j AVIfeCxpeDll+XeZOUDeM+elTDfQRUaLh47bhIXi2J128OApqxqKP5tI+KpQtQ4cwQVD 90Eqnn8UkBdjx3+kz10bRN6hDJuRDxc+vkTcylFdczRbumy54bt4x9tdOlfJpfg4kBm0 gpGLyCUsHxihZX6KI5hM3pqp/tN39o9miiXC0QPhw3DSybGx1Yx2LLWH4I7iQtgRRpYb 0R+11wUKAY38CC4HAzcRArmyf00tatH8J7ErUdog/aefWXktxFdI1QY7UXQiXrOLlvN+ 1hFg== X-Forwarded-Encrypted: i=1; AJvYcCXzn734uR5g5XCL9nIkDABszMGZ+3pD4+xzm2O8wv3BkfSpWNX+B3fsQaUk08m9EfvuWjoY7pVG72xRmbU=@vger.kernel.org X-Gm-Message-State: AOJu0YwglPPig8TyXbaI/nO5cNTzCXlVNJGZ9g1LpyM+jgVrSBX6SPcN A2MoSubJZjk34Q6CF2fSPHbIE5CpEaAUXAsGO7duvJqBFaKJjrcj5ALnGTEQgU4WmWOL7X9R47Y auEnI5jav3agAJW1PWIz0XcgfvzctQVU/IXMk331GtMfDQI562tZ97R1JfhZaEIWpfac= X-Gm-Gg: AeBDietgFHbg350vP91HnZMl/EJ5cUidxOScQM0THRE6s4BVSFzd4XjLbe722u8MZ9n 7lxWz9vZwllOKJN4pD0b13+3/evMkGh1A4vpbPqJGO/m/OGE93Odd9/8mpC8fRHjCWktcg42Tsu 9bKdg1nUPSFMpfmvv/SjSJjlY1mZJB7lj7oNxi3Wv2ryBwtQzgiAZbYybaRoB/iglY8mCa8F53F U8RfqPoNqdGU3YxzfPDJTOGvQcquTie2+9mLPRezy8WibRlKQvHwLL2xQg/hSIkSTOu9Nya3zfU buzwgYan4vh5oXhDj/Kp9ZI18SEZWeJtDbMgS7XvD4YLYxX7YNy3e9Cgz+ROk6NtdfppZJC+EIO yW7Og/mCH6bvaPmlvwgNxDGyGFrpF/f09m7S8z6vuFzFCIctmsdaaxjsNy1EUpkW5N/9Mq1heIk lXoh2jYXWYBog= X-Received: by 2002:a05:6a20:7d8a:b0:39b:dea7:5626 with SMTP id adf61e73a8af0-39f2f01de23mr16865058637.35.1775550807906; Tue, 07 Apr 2026 01:33:27 -0700 (PDT) X-Received: by 2002:a05:6a20:7d8a:b0:39b:dea7:5626 with SMTP id adf61e73a8af0-39f2f01de23mr16865009637.35.1775550807264; Tue, 07 Apr 2026 01:33:27 -0700 (PDT) Received: from [10.133.33.187] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c657e703sm14677176a12.22.2026.04.07.01.33.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 01:33:26 -0700 (PDT) Message-ID: <0a4911f4-168b-48c4-9554-3962d6e96efa@oss.qualcomm.com> Date: Tue, 7 Apr 2026 16:33:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: tpdm: fix invalid MMIO access issue To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260407-fix-potential-issue-in-tpdm-v1-1-42090d27c0a8@oss.qualcomm.com> <20260407081048.GJ356832@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260407081048.GJ356832@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: lWczT5m6bwbPlHp65p0kSeH_AukbAUzZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA3OCBTYWx0ZWRfX2O368FntNL8K 6h7ku+y+17l17L8s/xRKWnGOO5pENIwppa2BFG1ZqLAa23UrEhcQ2ichDRrYGaaiOEJPoLygOj9 iY49cRlohQQR4HYp1IitGi8JadTgn1kdszNbTRY8GnI1p6P5YdCDxr+0AFHtnNMmhMdER7BPqzv 0a5D49C0javdiHipILRz8nxTo4wBzWUPyrMtdcjg0i/gV6fisJJOGht6Wlz92TCEi/FHSxnhb/A gfr0VMrFaA2RoGRXzWvq7bToiHlUJCsDJygKOy5ioI4dh3FiJh9Ej7+BC1xCFV9Unh1dkHpafuY aip7Js7AmDz/gsorJIAWVUuKzaQRJqu65oIjvjtC/2TNOjq04KsUfqXOCfnmMXBA92j664Yub0i 2pcaNElVqJmsAXzsC8lfbXbysZlqvA8Odqu163HeEbLUwb9e6IVidl3JRDW7anYsvgqszaXapK+ pQ191ezp9qn6PLTlNXQ== X-Authority-Analysis: v=2.4 cv=BKGDalQG c=1 sm=1 tr=0 ts=69d4c158 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=zqWVOipMogyA4RGV3iUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: lWczT5m6bwbPlHp65p0kSeH_AukbAUzZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070078 Hi Leo On 4/7/2026 4:10 PM, Leo Yan wrote: > On Tue, Apr 07, 2026 at 12:47:11PM +0800, Jie Gan wrote: >> Create the csdev_access struct only when a valid MMIO resource is >> available. In tpdm_probe(), base is uninitialized for static TPDM >> instances that lack an MMIO resource, causing csdev_access to be >> created with a garbage address and potentially leading to >> unexpected issues. > > This patch itself is fine for me. However, I am wandering if this > is sufficient. > > As mentioned "potentially leading to unexpected issues", can I > understand some code pieces access register with uninitialized base? > If so, you would also explictly add coresight_is_static_tpdm() to > prevent register access. > Actually, we havent MMIO access for the static TPDM device, So no issues are observed. The commit message here may be misleading. do I need rephrase the commit message? Thanks, Jie > Thanks, > Leo > >> Fixes: 14ae052f7947 ("coresight: tpdm: add static tpdm support") >> Signed-off-by: Jie Gan >> --- >> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c >> index 9b16f368a58b..eaf7210af648 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >> @@ -1430,6 +1430,7 @@ static int tpdm_probe(struct device *dev, struct resource *res) >> if (ret) >> return ret; >> >> + desc.access = CSDEV_ACCESS_IOMEM(base); >> if (tpdm_has_dsb_dataset(drvdata)) >> of_property_read_u32(drvdata->dev->of_node, >> "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); >> @@ -1452,7 +1453,6 @@ static int tpdm_probe(struct device *dev, struct resource *res) >> desc.ops = &tpdm_cs_ops; >> desc.pdata = dev->platform_data; >> desc.dev = dev; >> - desc.access = CSDEV_ACCESS_IOMEM(base); >> if (res) >> desc.groups = tpdm_attr_grps; >> else >> >> --- >> base-commit: 816f193dd0d95246f208590924dd962b192def78 >> change-id: 20260407-fix-potential-issue-in-tpdm-b07b44416051 >> >> Best regards, >> -- >> Jie Gan >>