From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Hongwei Zhang" <hongweiz@ami.com>,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, "Jakub Kicinski" <kuba@kernel.org>,
"David Miller" <davem@davemloft.net>
Cc: "Joel Stanley" <joel@jms.id.au>
Subject: Re: [Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue
Date: Wed, 16 Dec 2020 09:17:36 +1030 [thread overview]
Message-ID: <0a513b26-a4e4-4808-a02a-eb6ffc84f5ba@www.fastmail.com> (raw)
In-Reply-To: <20201215192323.24359-2-hongweiz@ami.com>
On Wed, 16 Dec 2020, at 05:53, Hongwei Zhang wrote:
> Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit
> from macro RXDES0_ANY_ERROR.
But why? What is wrong with the EVB that this change resolves? Which revision
of the EVB?
The change affects all designs using the MAC, not just the AST2600 EVB. Why is
this patch an appropriate course of action? Can we not add a quirk targeting the
specific board (e.g. a devicetree property)?
Andrew
next prev parent reply other threads:[~2020-12-15 22:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 19:23 [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB " Hongwei Zhang
2020-12-15 19:23 ` [Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB " Hongwei Zhang
2020-12-15 20:31 ` Jakub Kicinski
2020-12-15 22:47 ` Andrew Jeffery [this message]
2020-12-21 17:00 ` [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB " Hongwei Zhang
2020-12-22 2:26 ` Joel Stanley
2020-12-22 2:43 ` [Aspeed, ncsi-rx, " Dylan Hung
2020-12-21 17:00 ` [Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB " Hongwei Zhang
2020-12-21 17:00 ` [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB " Hongwei Zhang
2020-12-21 17:00 ` [Aspeed,ncsi-rx, v1] Answer to initial submission Hongwei Zhang
2020-12-21 19:40 ` [Aspeed,ncsi-rx, v2 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue Hongwei Zhang
2020-12-21 19:40 ` [Aspeed,ncsi-rx, v2 1/1] net: ftgmac100: Fix AST2600 EVB " Hongwei Zhang
2020-12-21 22:09 ` Jakub Kicinski
2021-01-11 20:58 ` [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB " Hongwei Zhang
2021-01-11 20:59 ` [Aspeed,ncsi-rx, v2 1/1] " Hongwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a513b26-a4e4-4808-a02a-eb6ffc84f5ba@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=hongweiz@ami.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®