From: Leo Yan <leo.yan@arm.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
James Clark <james.clark@arm.com>,
Ian Rogers <irogers@google.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Nick Terrell <terrelln@fb.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Changbin Du <changbin.du@huawei.com>,
Fangrui Song <maskray@google.com>,
Mateusz Kowalczyk <fuuzetsu@fuuzetsu.co.uk>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 1/6] perf: build: Setup PKG_CONFIG_LIBDIR for cross compilation
Date: Fri, 7 Jun 2024 13:50:28 +0100 [thread overview]
Message-ID: <0a578e84-6a28-4477-9aa4-dcfb37fc28b0@arm.com> (raw)
In-Reply-To: <ZmHx2EFK9cSWgUIK@google.com>
Hi Namhyung,
On 6/6/24 18:28, Namhyung Kim wrote:
>> --- a/tools/build/feature/Makefile
>> +++ b/tools/build/feature/Makefile
>> @@ -82,7 +82,19 @@ FILES= \
>>
>> FILES := $(addprefix $(OUTPUT),$(FILES))
>>
>> -PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
>> +PKG_CONFIG ?= pkg-config
>> +
>> +ifdef CROSS_COMPILE
>> + ifndef PKG_CONFIG_LIBDIR
>
> Can we do that only if the cross-compile-pkg-config is not available?
Makes sense for me. I will update for this.
Thanks,
Leo
next prev parent reply other threads:[~2024-06-07 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 9:32 [PATCH v1 0/6] perf: build: Fix " Leo Yan
2024-06-04 9:32 ` [PATCH v1 1/6] perf: build: Setup PKG_CONFIG_LIBDIR for " Leo Yan
2024-06-06 17:28 ` Namhyung Kim
2024-06-07 12:50 ` Leo Yan [this message]
2024-06-04 9:32 ` [PATCH v1 2/6] perf: build: Append libtraceevent path in PKG_CONFIG_LIBDIR Leo Yan
2024-06-04 9:32 ` [PATCH v1 3/6] perf: build: Set Python configuration for cross compilation Leo Yan
2024-06-04 9:32 ` [PATCH v1 4/6] perf: build: Only link libebl.a for old libdw Leo Yan
2024-06-06 17:40 ` Namhyung Kim
2024-06-07 13:33 ` Leo Yan
2024-06-04 9:32 ` [PATCH v1 5/6] perf: build: Link lib 'lzma' for static build Leo Yan
2024-06-04 9:32 ` [PATCH v1 6/6] perf: build: Link lib 'zstd' " Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a578e84-6a28-4477-9aa4-dcfb37fc28b0@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=changbin.du@huawei.com \
--cc=fuuzetsu@fuuzetsu.co.uk \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=namhyung@kernel.org \
--cc=terrelln@fb.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®