From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965685AbdGTWo5 (ORCPT ); Thu, 20 Jul 2017 18:44:57 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:47321 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934851AbdGTWo4 (ORCPT ); Thu, 20 Jul 2017 18:44:56 -0400 Subject: Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe To: David Miller CC: , , , , , , , References: <1500550192-6550-1-git-send-email-j-keerthy@ti.com> <5259f0e7-cc5d-35c9-8f09-94cf7b40f653@ti.com> <20170720.152831.802536956243282259.davem@davemloft.net> From: Grygorii Strashko Message-ID: <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com> Date: Thu, 20 Jul 2017 17:44:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720.152831.802536956243282259.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2017 05:28 PM, David Miller wrote: > From: Grygorii Strashko > Date: Thu, 20 Jul 2017 11:08:09 -0500 > >> In general patch looks good to me, but it's really unexpected to >> receive IRQs while CPSW is probing ;( > > This is a poor expectation. > > Boot loaders and other entities can leave the device in any state > whatsoever. > > Furthermore, enabling an IRQ whose handler cannot properly execute > without crashing is wrong fundamentally. All data structures and > state must be set up properly before the IRQ is requested. > > Therefore this patch is correct and I will apply it. > Thanks. Agree (it just has never triggered before, so I meant - unexpected from current driver code point of view ;(). And I'm just worry that it might not be enough :(, especially for am335x. -- regards, -grygorii