From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A07B667 for ; Sun, 29 Sep 2024 02:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727576694; cv=none; b=KB3gEg0TQtr9InhxuIYr2a6KonDna7WWKWsrfBIzkdx2N1WNWIqGT5xjlGUawcHYKlnUKEA4p2pWkyRhBImdwuZav1WwPyU5reEG0trGpWBXFX5EVLL3Tmnt6SeSGDIizagcDAJDt8T6QuofSAyMAx5jcesxJ1Vlez813iYpEvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727576694; c=relaxed/simple; bh=cBICq7Yw77KRwv/0M6WtodAXrSpzg5xQV/fSitTTGNE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OQshNratm4p+WMYWrRCcI3vX8X5h5YrYxtF+/KK+sfRcbVLXpRmx8pzojcDVwowDn9ixS0W6Zf0xEl5dMJaIkoL2TWctbfOBPqJzcGoJjT6So2ItJgeno1QyRZP+VLVcyJdINMeI6Y8T0ExUSZDUV1iXnTls044koJApIvduGPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=ceal/QgE; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="ceal/QgE" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-718e285544fso2594859b3a.1 for ; Sat, 28 Sep 2024 19:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1727576692; x=1728181492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7J9loi/LLkdFcZG+N1SNYfaAIF+3tAmLLQpGcvQRn84=; b=ceal/QgEJjidDKqkg3TYWHfsDLvspF21Nudo+q/By9Y9vjMIFI6Mxth91XVa4+5rAz 9IcAeKti+7Kzw5dlqDp7YKg6wXosjcHSUDpMjNlXTw+gpg5CV+RQRV9mpKuKv4tTmLan UU3wUrFppYWkZNzZ4HwB1oCTCXQvfVFM0n1MsRiESO2MrjbkjTYVCkelMc4mGQS29m+R Mjz0tn52ufZszfgjL6wFundzw2MksNw7SqjTK10IoXNQiro9fU5V8WJtiDNL1/g1rh2r QZ8/I203HE3Bztdrm/jzF31ldD1WrpNhUWXBYmvD+NHexjc5lsk+QHsWDtohAKs/2xLS o7Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727576692; x=1728181492; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7J9loi/LLkdFcZG+N1SNYfaAIF+3tAmLLQpGcvQRn84=; b=wMmLFNwQ+rM6HKTcj6H8VAsGhylWGxmnQZ9+LCrE5A7RHs0J0YD9j8pdqb4gTyKR1o 0v2XbBFjNqEMg9rp/TYwHYQGzpikh1s7DPPuL/fgioESgEmj6GDAUf/1fmt/i6/ia/Bj F6fMVRfKPwNWR35j94A5LNIV6CSLHrmdGrBEyhqL/bf1Cy3XNmADumQ8TyShH2iYMgK1 feVLtFGj00p2G9a2aUCEmRL0xsTx16YT7o9wweUrlMpCsIi3c4dnOVijXvIY+tXTTsjU ceKQ8q5D4fa4orGMdysVwXAVcmPvn4k939IUBIseN0k10Hd8b0htq6Tye/8c0Fz7AxWY 1UXg== X-Forwarded-Encrypted: i=1; AJvYcCUaCY3D7yNXo4ToOG078R5ia/HWsiwBAI+jXcVjzPf7JnggPHNuvZ2bNMzHljJ+ZfuYJneruAF6t7AhIm8=@vger.kernel.org X-Gm-Message-State: AOJu0YxeY2wPjFq4fia04rGz/YaDXJcwRShwae9E+AY0scIwMjUmHY+M pAH1h3wh5oSIDvUQhbEApKhU8CblqYkJJqsfai2TAF4pi5MAavOIxHoZE0tlOi4= X-Google-Smtp-Source: AGHT+IFKqKBstTmcEl8Pn3z+AfZJxb9xQL3LJdSJptREBAQiCuJU5bU5xkhlIFPtdVGXmMq5nCkFrw== X-Received: by 2002:a05:6a00:6110:b0:714:1bd8:35f7 with SMTP id d2e1a72fcca58-71b25f6ef3dmr8184202b3a.15.1727576692161; Sat, 28 Sep 2024 19:24:52 -0700 (PDT) Received: from [10.70.146.105] ([203.208.189.13]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bc443sm3819772b3a.70.2024.09.28.19.24.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Sep 2024 19:24:51 -0700 (PDT) Message-ID: <0a5f0b71-2478-456e-bf4f-5132fb4f255d@bytedance.com> Date: Sun, 29 Sep 2024 10:24:43 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] [PATCH -next] perf test: Use ARRAY_SIZE for array length Content-Language: en-US To: Jiapeng Chong , peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20240927084002.8437-1-jiapeng.chong@linux.alibaba.com> From: Yang Jihong In-Reply-To: <20240927084002.8437-1-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 9/27/24 16:40, Jiapeng Chong wrote: > Use of macro ARRAY_SIZE to calculate array size minimizes > the redundant code and improves code reusability. > > ./tools/perf/tests/demangle-java-test.c:31:34-35: WARNING: Use ARRAY_SIZE. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11173 > Signed-off-by: Jiapeng Chong > --- > tools/perf/tests/demangle-java-test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/demangle-java-test.c b/tools/perf/tests/demangle-java-test.c > index 44d1be303b67..611c18cdf4d3 100644 > --- a/tools/perf/tests/demangle-java-test.c > +++ b/tools/perf/tests/demangle-java-test.c > @@ -6,6 +6,7 @@ > #include "session.h" > #include "debug.h" > #include "demangle-java.h" > +#include "kselftest.h" The wrong header file is included here, causing the build to fail: CC tests/demangle-java-test.o tests/demangle-java-test.c:9:10: fatal error: kselftest.h: No such file or directory 9 | #include "kselftest.h" | ^~~~~~~~~~ The correct header file to include should be: Thanks, Yang > > static int test__demangle_java(struct test_suite *test __maybe_unused, int subtest __maybe_unused) > { > @@ -28,7 +29,7 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte > "void java.lang.Object()" }, > }; > > - for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) { > + for (i = 0; i < ARRAY_SIZE(test_cases); i++) { > buf = java_demangle_sym(test_cases[i].mangled, 0); > if (strcmp(buf, test_cases[i].demangled)) { > pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,