From: Tim Chen <tim.c.chen@linux.intel.com>
To: Chen Yu <yu.c.chen@intel.com>, Aaron Lu <aaron.lu@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>
Cc: Deng Pan <pan.deng@intel.com>,
tim.c.chen@intel.com, linux-kernel@vger.kernel.org,
tianyou.li@intel.com, yu.ma@intel.com, lipeng.zhu@intel.com
Subject: Re: [PATCH v2] sched/task_group: Re-layout structure to reduce false sharing
Date: Mon, 26 Jun 2023 10:09:10 -0700 [thread overview]
Message-ID: <0a611696cbc63a3a9b99a7966b8fe4f7e20a014b.camel@linux.intel.com> (raw)
In-Reply-To: <ZJlDsbyNmcKtweg4@chenyu5-mobl2.ccr.corp.intel.com>
On Mon, 2023-06-26 at 15:52 +0800, Chen Yu wrote:
>
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index ec7b3e0a2b20..067f1310bad2 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1958,8 +1958,10 @@ static inline void set_task_rq(struct task_struct *p, unsigned int cpu)
> #endif
>
> #ifdef CONFIG_RT_GROUP_SCHED
> - p->rt.rt_rq = tg->rt_rq[cpu];
> - p->rt.parent = tg->rt_se[cpu];
> + if (p->sched_class = &rt_sched_class) {
> + p->rt.rt_rq = tg->rt_rq[cpu];
> + p->rt.parent = tg->rt_se[cpu];
> + }
If we avoid the assignment for non-rt task, do you see it further improves
c2c bounce?
Tim
next prev parent reply other threads:[~2023-06-26 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:14 Deng Pan
2023-06-26 5:47 ` Aaron Lu
2023-06-26 7:52 ` Chen Yu
2023-06-26 12:53 ` Aaron Lu
2023-06-27 8:05 ` Chen Yu
2023-06-27 10:10 ` Peter Zijlstra
2023-06-26 17:09 ` Tim Chen [this message]
2023-06-27 8:08 ` Chen Yu
2023-06-27 14:52 ` Deng, Pan
2023-06-26 12:51 ` Deng, Pan
2023-06-27 10:14 ` Peter Zijlstra
2023-06-27 16:12 ` Deng, Pan
2023-07-06 14:05 ` Deng, Pan
2023-06-28 5:18 ` Aaron Lu
2023-06-30 9:35 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a611696cbc63a3a9b99a7966b8fe4f7e20a014b.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=aaron.lu@intel.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng.zhu@intel.com \
--cc=mingo@redhat.com \
--cc=pan.deng@intel.com \
--cc=peterz@infradead.org \
--cc=tianyou.li@intel.com \
--cc=tim.c.chen@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
--cc=yu.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®