From: Andy Lutomirski <luto@MIT.EDU>
To: Arnaud Lacombe <lacombar@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@MIT.EDU>
Subject: [PATCH] x86-32: Fix boot with CONFIG_X86_INVD_BUG
Date: Thu, 25 Aug 2011 16:10:33 -0400 [thread overview]
Message-ID: <0a627e9f49e26554cacdb4049e4c09fa94ca76b6.1314302910.git.luto@mit.edu> (raw)
In-Reply-To: <CAObL_7HLpji6xDcBAmwUXBQuahLLVzQXAfYz_gXufUqj_cDzeQ@mail.gmail.com>
entry_32.S contained a hardcoded alternative instruction entry, and
the format changed in:
commit 59e97e4d6fbcd5b74a94cb48bcbfc6f8478a5e93
Author: Andy Lutomirski <luto@mit.edu>
Date: Wed Jul 13 09:24:10 2011 -0400
x86: Make alternative instruction pointers relative
Replace it with the altinstruction_entry macro. This fixes the
32-bit boot with CONFIG_X86_INVD_BUG=y.
Reported-by: Arnaud Lacombe <lacombar@gmail.com>
Signed-off-by: Andy Lutomirski <luto@mit.edu>
---
Arnaud, can you test this?
Thanks,
Andy
arch/x86/kernel/entry_32.S | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 5c1a9197..f3f6f53 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -54,6 +54,7 @@
#include <asm/ftrace.h>
#include <asm/irq_vectors.h>
#include <asm/cpufeature.h>
+#include <asm/alternative-asm.h>
/* Avoid __ASSEMBLER__'ifying <linux/audit.h> just for this. */
#include <linux/elf-em.h>
@@ -873,12 +874,7 @@ ENTRY(simd_coprocessor_error)
661: pushl_cfi $do_general_protection
662:
.section .altinstructions,"a"
- .balign 4
- .long 661b
- .long 663f
- .word X86_FEATURE_XMM
- .byte 662b-661b
- .byte 664f-663f
+ altinstruction_entry 661b, 663f, X86_FEATURE_XMM, 662b-661b, 664f-663f
.previous
.section .altinstr_replacement,"ax"
663: pushl $do_simd_coprocessor_error
--
1.7.6
next prev parent reply other threads:[~2011-08-25 20:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 15:42 [GIT PULL] x86/vdso changes for v3.1 Ingo Molnar
2011-08-25 5:58 ` Arnaud Lacombe
2011-08-25 6:05 ` Arnaud Lacombe
2011-08-25 11:51 ` Andrew Lutomirski
2011-08-25 14:06 ` Arnaud Lacombe
2011-08-25 19:16 ` Andrew Lutomirski
2011-08-25 19:37 ` Arnaud Lacombe
2011-08-25 19:47 ` Arnaud Lacombe
2011-08-25 19:49 ` Andrew Lutomirski
2011-08-25 19:51 ` Andrew Lutomirski
2011-08-25 19:51 ` H. Peter Anvin
2011-08-25 19:55 ` Andrew Lutomirski
2011-08-25 20:00 ` H. Peter Anvin
2011-08-25 20:10 ` Andy Lutomirski [this message]
2011-08-25 20:21 ` [PATCH] x86-32: Fix boot with CONFIG_X86_INVD_BUG Arnaud Lacombe
2011-08-25 20:28 ` Linus Torvalds
2011-08-25 19:55 ` [GIT PULL] x86/vdso changes for v3.1 Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a627e9f49e26554cacdb4049e4c09fa94ca76b6.1314302910.git.luto@mit.edu \
--to=luto@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=lacombar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®