From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88B7C55ABD for ; Thu, 12 Nov 2020 11:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46911221FE for ; Thu, 12 Nov 2020 11:29:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nu/S8C1Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbgKLL3Y (ORCPT ); Thu, 12 Nov 2020 06:29:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727147AbgKLL3W (ORCPT ); Thu, 12 Nov 2020 06:29:22 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F4BBC0613D4 for ; Thu, 12 Nov 2020 03:29:22 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id r17so5653489wrw.1 for ; Thu, 12 Nov 2020 03:29:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kEGmo14fLBYd6nSV3jI87mJ9Na1xum6NrqwdS4+IQ9Y=; b=nu/S8C1Yfzo9SHPOKV654ix3Bn7t9atAD7AUykvxjLXtDBitsoIhyQBnn0xD4aS7gx cT/hR+koIINFS5aszapJJqOPFA0xDNRQ9aw1H9aE4HtH8AYnfVnp4zZONs7JhK95tV+b yoTLe/bA1W1GKaoUSP+ygtMYupwIp4iCWgtjZDg0cXh7iaEYsJ8Jg2zpDecd897p8qrG ZmFGkJk3MrTdN3AuPYE3zAZkK5Xm+IaB7T2zVMCxpIY8nMqsLrIq6/8IppPlOjIj70ca j3blFEFrL8WguNYDLTlMgHhu8p+MKEqk4Jkq+u7rG90RfcgOktY4EbTyaSMhxsAfWE5c wuXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kEGmo14fLBYd6nSV3jI87mJ9Na1xum6NrqwdS4+IQ9Y=; b=pJOX7i21Fo7I+Z2ijHTb9pEKd3/KXnNJTLba+PQUegQeTBHHNezTy8Qf/TYUpYFyHH eMyJoJbTFiTX0soW4FjUQ6X391JqbBLW1rNKSRa1WbK35SO3l13Ea0XTYpYprKJm+8gi Cdg4qeiJRUQu11eq4OtbVwPvVAPYONIdmfe2Y7QOtShW6BTU26mI9mWF9RqwbtybvLJa YIex1Po8LYJ8GJShuWKGI5LKi63PSjiCCeDnau+QFhU4gxPGJa5EGNFKwWAzRIeRtn5B jjmVjt9+EqfIeEkESD6ZGHNspXP2Jg5DT5mSGdgoOZ5ystrmTqtCu3I0viFJO4BpudSQ a9qQ== X-Gm-Message-State: AOAM531qcMx6YYWNK/UAvfa7av3uAC7PXb+jzedRBejW1WmDhMFJkxTJ AHQyvo0fDPkOuW+AzIdoy7QasCtuJUZavQ== X-Google-Smtp-Source: ABdhPJxyFdKh+yZ6q8Rw1tY96SUPbmpWmKbb2vOHAkpwQyJDdNnfM7LsQRWGdffrTxd7Amuh5Mswqw== X-Received: by 2002:a5d:4f12:: with SMTP id c18mr16332843wru.304.1605180560855; Thu, 12 Nov 2020 03:29:20 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:6971:b700:3764:fa96? ([2a01:e34:ed2f:f020:6971:b700:3764:fa96]) by smtp.googlemail.com with ESMTPSA id u8sm6233604wmg.6.2020.11.12.03.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 03:29:20 -0800 (PST) Subject: Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH. To: Andres Freund , Srinivas Pandruvada Cc: Tushar Dave , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200115184415.1726953-1-andres@anarazel.de> <2a5e9df32e2df27297149a577512f6b1557de241.camel@linux.intel.com> <20200116184250.qlvc3ilx2b42czqk@alap3.anarazel.de> <2de70e961f24592d2d157b8586526df2eaf0ae6e.camel@linux.intel.com> <20201028202101.2m2jp3tfa6mh3brz@alap3.anarazel.de> From: Daniel Lezcano Message-ID: <0a62fbb3-a858-02ca-b89d-5234775da4a4@linaro.org> Date: Thu, 12 Nov 2020 12:29:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201028202101.2m2jp3tfa6mh3brz@alap3.anarazel.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/2020 21:21, Andres Freund wrote: > Hi, > > On 2020-01-16 11:41:34 -0800, Srinivas Pandruvada wrote: >> On Thu, 2020-01-16 at 10:42 -0800, Andres Freund wrote: >>> Hi, >>> >>> On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote: >>>> On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote: >>>>> I noticed that I couldn't read the PCH temperature on my >>>>> workstation >>>>> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but >>>>> had to >>>>> go >>>>> through IPMI. Looking at the data sheet, it looks to me like the >>>>> existing intel PCH thermal driver should work without changes for >>>>> Lewisburg. >>>> Does the temperature reading match with what you read via IPMI? >>> >>> It does: >>> >>> root@awork3:~# ipmitool sdr|grep ^PCH >>> PCH Temp | 58 degrees C | ok >>> >>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type >>> pch_lewisburg >>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp >>> 58000 >>> >>> And if I generate some load, it rises for both: >>> root@awork3:~# ipmitool sdr|grep ^PCH >>> PCH Temp | 60 degrees C | ok >>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp >>> 60000 >>> >> Thanks for the test. >> >> Rui can add his ACK. > > Ping? Looks like this got lost somewhere? Waiting for Rui's ack :) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog