From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbdKIQ3H (ORCPT ); Thu, 9 Nov 2017 11:29:07 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:63162 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdKIQ3E (ORCPT ); Thu, 9 Nov 2017 11:29:04 -0500 Subject: Re: [PATCH 1/9] ASoC: tlv320aic31xx: Fix typo in DT binding documentation To: Philipp Zabel , Liam Girdwood , Mark Brown , Rob Herring , Mark Rutland , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Shawn Guo , Sascha Hauer CC: , , References: <20171108212505.28320-1-afd@ti.com> <20171108212505.28320-2-afd@ti.com> <1510237517.7659.10.camel@pengutronix.de> From: "Andrew F. Davis" Message-ID: <0a640aec-1c8e-f778-3a72-f7d012e0604e@ti.com> Date: Thu, 9 Nov 2017 10:28:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510237517.7659.10.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2017 08:25 AM, Philipp Zabel wrote: > Hi Andrew, > > On Wed, 2017-11-08 at 15:24 -0600, Andrew F. Davis wrote: >> The property used to specify a GPIO intended for reset is "reset-gpio", >> this binding uses "gpio-reset", as almost all other bindings use the >> former name this use of the latter is certainly not intended and >> was a typo. It is not compatible with newer methods used to fetch >> GPIO pins and to prevent the spread of this error to other bindings >> lets fix this here. >> >> We also standardize the pin as active-low, different device trees have >> marked the GPIO different ways, luckily the driver currently uses the >> low-level GPIO set function which does not respect the active-low flag, >> but future changes may change this. This is an active-low reset, mark >> it as such. >> >> Lastly, add an example of use for this property. >> >> Fixes: e00447fafbf7 ("ASoC: tlv320aic31xx: Add basic codec driver implementation") >> >> Signed-off-by: Andrew F. Davis >> --- >> Documentation/devicetree/bindings/sound/tlv320aic31xx.txt | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt >> index 6fbba562eaa7..4c4e77f97d87 100644 >> --- a/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt >> +++ b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt >> @@ -22,7 +22,7 @@ Required properties: >> >> Optional properties: >> >> -- gpio-reset - gpio pin number used for codec reset > > I would move this into a "Deprecated properties:" section instead of > just hiding it away. > The hope was to fix this mistake and pretend it never existed :) I'll add a Deprecated section in case this breaks for someone they can see that it was changed. >> +- reset-gpio - GPIO specification for the active low RESET input. > > This should be "reset-gpios". For reference, see > Documentation/devicetree/bindings/gpio/gpio.txt. > Yup, will fix for v2. >> - ai31xx-micbias-vg - MicBias Voltage setting >> 1 or MICBIAS_2_0V - MICBIAS output is powered to 2.0V >> 2 or MICBIAS_2_5V - MICBIAS output is powered to 2.5V >> @@ -48,6 +48,7 @@ CODEC input pins: >> The pins can be used in referring sound node's audio-routing property. >> >> Example: >> +#include >> #include >> >> tlv320aic31xx: tlv320aic31xx@18 { >> @@ -56,6 +57,8 @@ tlv320aic31xx: tlv320aic31xx@18 { >> >> ai31xx-micbias-vg = ; >> >> + reset-gpio = <&gpio1 17 GPIO_ACTIVE_LOW>; >> + >> HPVDD-supply = <®ulator>; >> SPRVDD-supply = <®ulator>; >> SPLVDD-supply = <®ulator>; > > regards > Philipp >