From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-14183-1520980042-2-7242773004353257916 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.249, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520980041; b=IDDBHSdrNPWGjekwLgDeIr+Jlvck3t8ICOFyoVSYWgw9fr5 zGKKpRUlLLy0iGvWQUV8IoHlTFuCeUkx9WQPr+F/6LhGLeks3ly4hTClYlsmL8Iz Qv54eNu82T7yGfjVpdlriFNs7ClRbIp5Opo0Cm4P4dBDkiMV/lEsitYYxJthdG01 n+RpbNygndpEsoXtbObVzp4PD8Azur3ReWCLREeuMJ69Av3LxCZXt+dFKyFhQyNW nfbfWAJzhamBU0fa3D/L8oluSekZQbr9YcG/veECoSaCTWhdSMPnPQW11srCUAIh OOJrLEQ1gXKq8G2wYTyBc9/0fvQkJilG+0fCYIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:references:from:message-id :date:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc :content-transfer-encoding:content-type:sender; s=arctest; t= 1520980041; bh=QY0LPuP7W9W+WrFrDwSdTvwFjWaYrxabCqHCI7cwips=; b=r k5reNCv77CEPgO9VvtV+YQ/wVkgr1wRf3avzMba9LKT3IIybTABVn3MpIhQMTSrt bzTrif27Z9VrWftWP6+g02YXrkaY/jTiLFv8mFymMS1WmfCjSfi2QsGVstBVcffW C8dgUTxdNlXtlt+ADiB4EJvLc5SqINtcJcXIofC3kTyf+WRKZQ1mo1CxurhWEyIw iZkjKGiVxnbt5TUIGTBpHjyFOBk3nLc7jc61SmFTcXD6TREPEtb+z0Zltj9csQcU iRzQ+kKi5Ki3wFWRuOdxT6Z+hah4/ux4DNoxs3ukj4+kEPAUqnCHqJjsjO/XbSZB bZ+4u4pUUiR771ki8vncw== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=P5WylioQ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=E3AiXek8; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=P5WylioQ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=E3AiXek8; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AG47ELtQnftBckYCz2E8T3+/DvvCiVx38j5yUTeeBPaauUQHmiiUQib1z3NxFbk9T83IDQsoB3FnIg== Subject: Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry To: Peter Seiderer References: <20180313200054.31305-1-ps.report@gmx.net> <20180313232449.253c7626@gmx.net> From: Steve Longerbeam Message-ID: <0a65c663-ee8f-3edb-92ae-426910da9352@gmail.com> Date: Tue, 13 Mar 2018 15:27:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180313232449.253c7626@gmx.net> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 03/13/2018 03:24 PM, Peter Seiderer wrote: > Hello Steve, > > On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam wrote: > >> Hi Peter, >> >> Thanks for the patch. >> >> This needs to be done in imx-ic-prpencvf.c as well, see >> prp_vb2_buf_done(). > Ahh, I see...., would you prefer an follow up patch or > an v2 patch doing the changes on mx-media-csi.c and > imx-ic-prpencvf.c at once? Hi Peter, a v2 patch would be fine. Steve > On 03/13/2018 01:00 PM, Peter Seiderer wrote: >>> Signed-off-by: Peter Seiderer >>> --- >>> drivers/staging/media/imx/imx-media-csi.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c >>> index 5a195f80a24d..3a6a645b9dce 100644 >>> --- a/drivers/staging/media/imx/imx-media-csi.c >>> +++ b/drivers/staging/media/imx/imx-media-csi.c >>> @@ -111,6 +111,7 @@ struct csi_priv { >>> struct v4l2_ctrl_handler ctrl_hdlr; >>> >>> int stream_count; /* streaming counter */ >>> + __u32 frame_sequence; /* frame sequence counter */ >>> bool last_eof; /* waiting for last EOF at stream off */ >>> bool nfb4eof; /* NFB4EOF encountered during streaming */ >>> struct completion last_eof_comp; >>> @@ -234,8 +235,11 @@ static void csi_vb2_buf_done(struct csi_priv *priv) >>> struct vb2_buffer *vb; >>> dma_addr_t phys; >>> >>> + priv->frame_sequence++; >>> + >>> done = priv->active_vb2_buf[priv->ipu_buf_num]; >>> if (done) { >>> + done->vbuf.sequence = priv->frame_sequence; >>> vb = &done->vbuf.vb2_buf; >>> vb->timestamp = ktime_get_ns(); >>> vb2_buffer_done(vb, priv->nfb4eof ? >>> @@ -543,6 +547,7 @@ static int csi_idmac_start(struct csi_priv *priv) >>> >>> /* init EOF completion waitq */ >>> init_completion(&priv->last_eof_comp); >>> + priv->frame_sequence = 0; >>> priv->last_eof = false; >>> priv->nfb4eof = false; >>> _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel